Fix typo of URL of sbol data model specification #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmitchell
requested changes
Mar 24, 2023
.gitignore
Outdated
| @@ -6,3 +6,4 @@ build/ | |||
| dist/ | |||
| # Emacs backup files | |||
| *~ | |||
| test/SBOLTestSuite | |||
There was a problem hiding this comment.
Why is this being ignored? Is this part of the URL change? I don't think this is right.
|
This is a good catch, thanks for updating the URL. The sbolstandard web site was migrated last year and the URL must have changed as part of that migration. You are correct that the URL should be updated in |
tcmitchell
requested changes
Mar 24, 2023
tcmitchell
requested changes
Mar 24, 2023
.vscode folder was created automatically when I run unittest for specific branch. I found that this folder was unnecessary, so I have deleted it and removed from gitignore file
|
Finally reverted the file Now, the .gitignore file in my branch is the same as the one on the main |
tcmitchell
approved these changes
Mar 27, 2023
Omarelsherif010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
constant.pyfile the URL of SBOL data model specification is not correct.I am not sure if it is better to change the URL itself to look like the one written in file or change the one in file for now until next update.
currently this make the URL inside the file send the user to SBOL data model specification website.
fixes #424