Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Correct Finnish localizations #563

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

Mikaela
Copy link

@Mikaela Mikaela commented Nov 5, 2022

I am performing code --diff messages_fi.py messages_en.py and attempting to correct what I see wrong with #561.

I am not able to correct everything or see some parts aren't great, so other localizers would be welcome. I am also taking liberties especially where I just don't see a way for the English wording working translated directly.

Copy link
Author

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally submit two oneliner comments instead of making finalised review, where I may be attempting to justify my decisions a bit too hard compared to actually correcting the localization.

syncplay/messages_fi.py Outdated Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Outdated Show resolved Hide resolved
syncplay/messages_fi.py Outdated Show resolved Hide resolved
syncplay/messages_fi.py Outdated Show resolved Hide resolved
Copy link
Author

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't continue as much as I wished and did this a bit too late cutting to my bedtime, but this is not a race.

syncplay/messages_fi.py Outdated Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
syncplay/messages_fi.py Show resolved Hide resolved
Copy link
Author

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes to self that came up

syncplay/messages_fi.py Outdated Show resolved Hide resolved
syncplay/messages_fi.py Outdated Show resolved Hide resolved
@Et0h
Copy link
Contributor

Et0h commented Dec 22, 2022

@Mikaela Please let me know when you consider this ready to merge.

@Mikaela
Copy link
Author

Mikaela commented Dec 22, 2022

I will, my apologies for the delay, I want to get this done and feel guilty for the lack of progress.

I have been having challenges with mental and physical health and xmas is always somewhat difficult time for me.

@Et0h
Copy link
Contributor

Et0h commented Dec 22, 2022

I will, my apologies for the delay, I want to get this done and feel guilty for the lack of progress.

I have been having challenges with mental and physical health and xmas is always somewhat difficult time for me.

Syncplay development is voluntary, so please prioritise your health and take as long as you need.

@Et0h
Copy link
Contributor

Et0h commented Feb 7, 2023

@Mikaela Would it be fine for me to merge the work you've done so far so that others can work on the translation, and then you can work on the translation further if and when you are in the right place based on the latest version?

@Mikaela
Copy link
Author

Mikaela commented Feb 8, 2023

I guess that is for the best, thanks for proposing it, I will attempt to unmark draft.

I was thinking of this PR in recent days while visiting family, but obviously I didn't get around to it.

I have watched one serie using this branch and have been talking about watching another, maybe that will be the encouragement I need.

@Mikaela Mikaela marked this pull request as ready for review February 8, 2023 06:03
@Et0h Et0h merged commit 871f7cf into Syncplay:Finnish_Translation Feb 28, 2023
Et0h added a commit that referenced this pull request Mar 14, 2023
* Add initial Finnish translation (credit: LINUX-SAUNA)
* Improvements by Mikaela (#563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants