-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Correct Finnish localizations #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally submit two oneliner comments instead of making finalised review, where I may be attempting to justify my decisions a bit too hard compared to actually correcting the localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't continue as much as I wished and did this a bit too late cutting to my bedtime, but this is not a race.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of notes to self that came up
@Mikaela Please let me know when you consider this ready to merge. |
I will, my apologies for the delay, I want to get this done and feel guilty for the lack of progress. I have been having challenges with mental and physical health and xmas is always somewhat difficult time for me. |
Syncplay development is voluntary, so please prioritise your health and take as long as you need. |
@Mikaela Would it be fine for me to merge the work you've done so far so that others can work on the translation, and then you can work on the translation further if and when you are in the right place based on the latest version? |
I guess that is for the best, thanks for proposing it, I will attempt to unmark draft. I was thinking of this PR in recent days while visiting family, but obviously I didn't get around to it. I have watched one serie using this branch and have been talking about watching another, maybe that will be the encouragement I need. |
* Add initial Finnish translation (credit: LINUX-SAUNA) * Improvements by Mikaela (#563)
I am performing
code --diff messages_fi.py messages_en.py
and attempting to correct what I see wrong with #561.I am not able to correct everything or see some parts aren't great, so other localizers would be welcome. I am also taking liberties especially where I just don't see a way for the English wording working translated directly.