Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ keyind to be used (mpv Next Chapter) #705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Assistant
Copy link
Contributor

This allows the default keybind for Next Chapter in mpv to be used when the option to automatically chat is enabled.

@Et0h
Copy link
Contributor

Et0h commented Dec 10, 2024

Thanks for this contribution. I use mpv, but I don't use the instant chat feature. It wold be nice to hear from at least one other person who would be impacted by this change about what they think the expected/ideal behaviour is.

@Assistant
Copy link
Contributor Author

Of course.
For context the current behavior is if you press @ instead of skipping to the next chapter it would open the chat and type "@" to it.
With this change pressing @ will skip to the next chapter, while allowing "@" to be typed if the chat is opened first.
I've been using this patch for a long time so I don't remember if it's possible to use the keybind bypassing the instant chat, but if it is I believe it wasn't very obvious.

@Et0h
Copy link
Contributor

Et0h commented Dec 10, 2024

I've been using this patch for a long time so I don't remember if it's possible to use the keybind bypassing the instant chat, but if it is I believe it wasn't very obvious.

According to https://syncplay.pl/guide/client/ "In some cases when in the ‘instant chat’ mode you might actually want to trigger one of the keys from the alphabet rows, such as Control+T to set set 'stay on top' to Yesand Control+Shift+T to set it to No. To do this you first have to press ‘Tab’ to enter into the ‘Alphabet rows temporarily behave as normal’ mode. You press tab again to exit that mode."

Pressing tab is also mentioned in the tooltip for the option within the configuration and within mpv input screen when the feature is enabled. It also tells you within mpv to press tab to let you know you have temporarily disabled it and to press tab again to return to instant chat mode.

@Assistant
Copy link
Contributor Author

Reading might not be my strong suit.
Regardless, personally the case where I want to go to the next chapter is a lot more frequent than the case where I want to start a chat message with "@", so I think that should be the easier option.

@Et0h
Copy link
Contributor

Et0h commented Dec 27, 2024

Before coming to a decision I'll ask some people listed in the Syncplay change logs as contributing to our mpv support in the past two years to give them an opportunity to share their perspective if they wish to do so: @mbalandis @notpeelz @soredake @ahmubashshir @ducreyna @hunbernd @Abu-AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants