Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross/nmap: fix build #4196

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Sep 28, 2020

Motivation: cross/nmap was no longer compiling

Checklist

  • [ ] Build rule all-supported completed successfully
  • [ ] Package upgrade completed successfully
  • [ ] New installation of package completed successfully

@hgy59
Copy link
Contributor

hgy59 commented Sep 28, 2020

@smaarn on #4195 I have updated nmap and recognized that CFLAGS="$(TC_EXTRA_CFLAGS)" is not required at all.

@smaarn
Copy link
Contributor Author

smaarn commented Sep 28, 2020

@smaarn on #4195 I have updated nmap and recognized that CFLAGS="$(TC_EXTRA_CFLAGS)" is not required at all.

I guess the least amount of code there is, the better :)

@smaarn smaarn force-pushed the fix/nmap/fix-cross-compiling-configure-args branch 2 times, most recently from e7401c3 to 58573d2 Compare September 28, 2020 11:35
@smaarn
Copy link
Contributor Author

smaarn commented Sep 28, 2020

@hgy59 following your feedback I removed the customization. At this stage I don't know what's your timeline in terms of delivery of #4195 so I'll let you decide whether or not to close this PR.

@smaarn smaarn changed the title cross/nmap: customized cflags would require quoting cross/nmap: fix build Sep 28, 2020
@hgy59 hgy59 mentioned this pull request Sep 29, 2020
3 tasks
hgy59 added a commit to ymartin59/spksrc that referenced this pull request Sep 29, 2020
@smaarn smaarn force-pushed the fix/nmap/fix-cross-compiling-configure-args branch from 58573d2 to dca5f7c Compare October 2, 2020 20:32
@hgy59 hgy59 self-requested a review October 3, 2020 07:39
@ymartin59 ymartin59 merged commit 1c5cf29 into SynoCommunity:master Oct 3, 2020
@smaarn smaarn deleted the fix/nmap/fix-cross-compiling-configure-args branch October 3, 2020 08:12
ymartin59 pushed a commit to ymartin59/spksrc that referenced this pull request Oct 4, 2020
hgy59 added a commit that referenced this pull request Oct 10, 2020
* mosquitto: update to 1.6.12
* fix configure options (similar to #4196)
* changes not already commited on #4068
- updated libwebsockets
- fix clock_gettime for arm5 and older ppc
- install mosquitto_rr too
- update icon
* use current config file
* support ppc853x by patch
* Fix openssl install for CMake to detect it
* fix make options #4210
* final fix for openssl 1.0.1
- remove openssl.cnf from PLIST as it was removed by using installed /etc/ssl/openssl.cnf

Co-authored-by: hgy59 <hpgy59@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants