Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & fix build of ruTorrent #4209

Merged
merged 21 commits into from
Oct 13, 2020
Merged

Update & fix build of ruTorrent #4209

merged 21 commits into from
Oct 13, 2020

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Oct 7, 2020

Motivation: Fed-up of seeing this package fail to build under github-action so this is a first trial at fixing things up and while at it updating the code base.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

IMPORTANT NOTES

@th0ma7 th0ma7 self-assigned this Oct 7, 2020
@ymartin59
Copy link
Contributor

@th0ma7 You may inspire from this closed PR #3175 from @Safihre

@ymartin59
Copy link
Contributor

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

@ymartin59
Copy link
Contributor

I propose to submit our "cross-compiling" patches upstream if relevant to ease future maintenance/update

@th0ma7
Copy link
Contributor Author

th0ma7 commented Oct 10, 2020

I propose to submit our "cross-compiling" patches upstream if relevant to ease future maintenance/update

Excellent point, done.

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

I'll see what I can do but really this was an easy no maintenance workaround... I'd rather just sticking to that solution as it may be useful elsewhere as well.

@th0ma7 th0ma7 changed the title [wip] Update to ruTorrent Update & fix build of ruTorrent Oct 10, 2020
@th0ma7
Copy link
Contributor Author

th0ma7 commented Oct 12, 2020

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

@ymartin59 I've quickly check and to my understanding cppunit checks are mandatory to get the rtorrent to build

I suggest we merge as-is for now until another solution is found... other solution would be to add cppunit to the docker image ans part of the Debian image howto procedure...

Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so you can merge with cppunit

@th0ma7 th0ma7 merged commit 9de705e into SynoCommunity:master Oct 13, 2020
@th0ma7 th0ma7 deleted the rtorrent branch October 13, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants