-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update & fix build of ruTorrent #4209
Conversation
I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one. |
I propose to submit our "cross-compiling" patches upstream if relevant to ease future maintenance/update |
Excellent point, done.
I'll see what I can do but really this was an easy no maintenance workaround... I'd rather just sticking to that solution as it may be useful elsewhere as well. |
@ymartin59 I've quickly check and to my understanding I suggest we merge as-is for now until another solution is found... other solution would be to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so you can merge with cppunit
Motivation: Fed-up of seeing this package fail to build under github-action so this is a first trial at fixing things up and while at it updating the code base.
Checklist
all-supported
completed successfullyIMPORTANT NOTES