Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ntopng to version 4.2 #4255

Merged
merged 12 commits into from
Nov 5, 2020
Merged

Update ntopng to version 4.2 #4255

merged 12 commits into from
Nov 5, 2020

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Nov 3, 2020

Motivation: Update was needed part of #4211 so now trying to update to latest version available.
Linked Items: #4254 (zeromq duplicate removal). Closes #3984

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

TODO

  • Update CHANGELOG to better reflect all the sub-package changes
  • Update lua package version
  • Update src/GeoLite2.mmdb.zip
  • review rw_locks to enable them on x64
  • review -Wno-address-of-packed-member compiler removal
  • Find issue with qoriq arch
  • Find issue with 88f6281 arch

@th0ma7 th0ma7 self-assigned this Nov 3, 2020
@th0ma7 th0ma7 changed the title Update ntopng to version 4.2 [WIP] Update ntopng to version 4.2 Nov 3, 2020
@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 3, 2020

@hgy59 as you are the maintainer, heads-up on this PR.
It now build properly on x64. Will require rework on rw_locks potentially.
At first glance it looks like installing & upgrading OK but it fails to login so can't really test functionality for now.
Haven't investigated the issue yet but now happy it does build!

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 3, 2020

It actually run really well. Clearly I needed some sleep as the issue was a forgoten password change.
It looks like running really well and is actually much more user friendly than 3.x branch. Looks promising.

@hgy59
Copy link
Contributor

hgy59 commented Nov 3, 2020

@th0ma7 thanks for setting this up. I never succeeded to build this version until now.

regarding your TODO: Update src/GeoLite2.mmdb.zip
I bundled the latest public available db GeoLite2.mmdb.zip. Since 2020 you cannot download updated db without a login.
So there is nothing to do here.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 3, 2020

@hgy59 give it a shot, it runs surprisingly well...

@th0ma7 th0ma7 changed the title [WIP] Update ntopng to version 4.2 Update ntopng to version 4.2 Nov 4, 2020
@th0ma7 th0ma7 requested a review from hgy59 November 4, 2020 02:06
@th0ma7 th0ma7 linked an issue Nov 4, 2020 that may be closed by this pull request
@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 4, 2020

@hgy59 is there a way I can provide a link from the build artifacts of github-action so a user can test it out (e.g. #3984)

@hgy59
Copy link
Contributor

hgy59 commented Nov 4, 2020

@hgy59 is there a way I can provide a link from the build artifacts of github-action so a user can test it out (e.g. #3984)

You find a "packages" link on the github action page.
Example for Build #679

There is always a single artifact file containing all spk files of all successfully built archs.

@hgy59
Copy link
Contributor

hgy59 commented Nov 4, 2020

@hgy59 give it a shot, it runs surprisingly well...

Yes, surprising 🥇. I tested on a very limited DS115j. The interaction is slow, but just works.

The version 4.2 is really new (just 2 days off). With version 4.0 I never succeeded to build (nDPI vs. ntopng).

Thanks for your good work.

Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just needs a rebase to include #4254

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 5, 2020

LGTM
just needs a rebase to include #4254

My nvme just died... lacking a PC for a few days.
Found one, gtg. PR was in a readiness state to use 4254, rebased with no changes. Merging.

@th0ma7 th0ma7 merged commit 0c7d951 into SynoCommunity:master Nov 5, 2020
@th0ma7 th0ma7 deleted the ntop42 branch November 5, 2020 11:58
@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 5, 2020

@hgy59 I just noticed you had updated lua to latest in background, good call and thnx.
Now merged. Package release will have to wait a bit until my RMA comes in unless you want to take it off the #4211 list yourself.

@hgy59 hgy59 added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/ready-to-merge labels Nov 5, 2020
@khashashin
Copy link

@th0ma7 and @hgy59 Thanks guys for the great work.
Can I refer to the official documentation when configuring the Synology version of ntopng?

I have a Fritz!Box router on my home network and I want to use this script (ntopng fritzdump.sh docs) to monitor the WAN interface. I tested this script on my Mac OS and to achieve the successful run, I had to do the following:

  1. stop the currently running ntopng: sudo launchctl unload /Library/LaunchDaemons/org.ntop.ntopng.plist.
  2. start the script fritzdump.sh: sudo ntopng/tools/fritzdump.sh <username> <password>
  3. launch ntopng: sudo launchctl load /Library/LaunchDaemons/org.ntop.ntopng.plist

After that I was able to see the traffic in the stdin interface:
image

So, my question is, could I login to my Synology 920+ through SSH (or using Task Scheduler) and do the steps above which I've done for Mac OS?

@hgy59
Copy link
Contributor

hgy59 commented Nov 19, 2021

@khashashin I don't know wheter the fritzdump.sh will run on your diskstation, but you can try...
To stop/start ntopng you can use the stop/start button in the package center of your diskstation.
Or on the command line use sudo synopkg stop ntopng and sudo synopkg start ntopng.

But please consider: there will be no ntopng package available in DSM 7, as starting ntopng needs root access.

@khashashin
Copy link

@hgy59 Thank you for your reply! I already have an upgrade to DSM 7 :(
I think the only way to me is to look at ntopng Docker version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request] ntopng
3 participants