Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix os_min_ver for noarch (followup for #4219) #4392

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 16, 2021

Motivation: Recover os_min_ver and firmware in INFO file for noarch packages
Linked issues: original behaviour was removed in #4219

@hgy59 hgy59 merged commit 6b958b7 into SynoCommunity:master Jan 16, 2021
hgy59 added a commit that referenced this pull request Jan 17, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate #4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Jan 17, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Jan 30, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Feb 1, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Feb 6, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Feb 20, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray pushed a commit to publicarray/spksrc that referenced this pull request Feb 21, 2021
- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate SynoCommunity#4392
- followup of 05c2383 to avoid to clean between builds
publicarray added a commit that referenced this pull request Mar 11, 2021
* prepare for dsm7

* Add 7.0 toolchain for testing

* Add x64-7.0 to CI

* start on dsm7 install/service script

* fix DSM_APP_NAME in dsm7

* remove tools that require root permissions:
  (synouser, synogroup, synoshare)
* remove tool that fail to modify permissions (synoacltool)
* remove tool that fail to apply configuration (servicetool)

servicetool, synouser, synogroup and synoshare have alternative
 ways to do the same thing using resource configuration

* fix username, keep DSM6 name convention sc-packagename

* Issue user facing warning on unsupported functions

* change package icon size

- change icon size from 72x72 to 64x64 for DSM 7

* cleanup

* Store log files, pid and other files in permanent storage
fixes missing log entries on reinstall

* Migrate some JSON processing to jq

TODO add moreutils package, use sponge to prevent overriding file with 0 content
- 1<> $@
+ | sponge $@

* fix adding GROUPs DSM7

* join-pkg-groupnames Creates group but is different from the groups the user can create, they are invisible in the UI an are only useful to access another packages permissions (ffmpeg comes to mind)
For DSM7 I recommend setting permissions for individual packages (System Internal User)
or use the shared folder resource worker to add permissions. We can ask the user from the wizard the folder name

"join-groupname": "http" is for system groups, mainly for the web service ("root" don't work but "system" does)

* DSM6->DSM7 move target/var to var/

* Added dsm7 preview toolchain for syno-armada38x-7.0

* Add DSM7.0 toolchains

* Add v1000 to generic x64-7.0

* Add evansport DSM 7.0 Toolkit

* fix builds for dsm versions < 7

* DSM7 Log install script to /var/log/packages/{package}.log

Remove some more statements that modify files in places where we don't have permissions or is just unnecessary in DSM7

* add back firewall install/removal

* Acquire Shared folder resource/permissions

set using SERVICE_WIZARD_SHARE

only disadvantage is that this does not support sub-folders currently

* Only migrate /var directory to permanent storage when destination is empty

* set SYNOPKG_PKGVAR for DSM versions less than 7.0

* Add uninstaller that can optionally remove all package files

Includes files in the new permanent storage (/var) and home folder

* uninstaller: also remove /etc

* fix noarch in dsm7

simple hack to set os_min_ver to 7.0-4000

build using: make noarch-7.0 or make noarch-6.1
build must be clean between builds

#4215 (comment)

* fix missing files on clean install
Copy config files on first install from "target/var" to "/var"

* Error on dropped support for busybox start-stop-daemon aka SERVICE_EXE

* fix don't override old configurations

* Add ability for packages to join a SYSTEM_GROUP and cleanup

Available options are: http and system

* fix DSM6 regression and code review

* fix regression: backwards compatibility with DSM6

* for DSM6 don't set "groupname". fixes permission issues with sc-{groups}

Add SPK_GROUP variable to override "groupname", default is sc-{packagename}

* fix noarch for dsm7

- use noarch-dsm7 to distinguish from noach-all
- use different work dirs for all and dsm7
- incorporate #4392
- followup of 05c2383 to avoid to clean between builds

* update github action to build noarch-7.0 packages

* fix github build action for noarch-7.0

* another fix for noarch build action

* fix DSM7 running with su command:
#4395 (comment)

* Toolchains: Update DSM7 hashes and fix typos

* Add supported DSM 7 archs to CI/GH Actions

* fix os_min_vers for DSM 7 noarch

- update min. build from 4000 to 40000

* regenerated digests of dsm7 toolchains

* Add sha256 digest to evansport toolkit

* fix TC_BUILD for DSM7.0

* Apply new version comparison function

Fixes wrong comparisons e.g. where 3.10 was erroneously less than 3.2

Thanks @th0ma7

* framework, resource: simplify jq command

* framework: code review

* Add linking support for /usr/local/lib and /usr/local/etc

depreciate SPK_LINKS and add new make variable: SPK_USR_LOCAL_LINKS

* fix SPK_USR_LOCAL_LINKS

* Fix comments being output to command line

* Framework: DSM7 Make sure folder exists before migrating files

* Framework: Fix unable to override uninstall wizard

* Update mk/spksrc.service.start-stop-status

Co-authored-by: hgy59 <hpgy59@gmail.com>

* Fraework: avoid creating wizard folder when it's not needed

Co-authored-by: hgy59 <hpgy59@gmail.com>

Co-authored-by: hgy59 <hpgy59@gmail.com>
Co-authored-by: root <zyrill@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant