Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet runtime: remove unsupported archs #5301

Merged
merged 4 commits into from
Dec 18, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jun 5, 2022

Description

Remove unsupported archs from ARMv7 archs.
This needs a small update in the INFO file creation.

Follow up of #5300

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@hgy59 hgy59 added the framework label Jun 5, 2022
@hgy59
Copy link
Contributor Author

hgy59 commented Jun 5, 2022

This update allows to remove unsupported from generic archs in the package INFO file.

@publicarray this is probably useful for jellyfin package, since all dotnet dependent packages do not support all ARMv7 archs.

@hgy59
Copy link
Contributor Author

hgy59 commented Jun 6, 2022

Considering #5283 armadaxp might be supported.

@publicarray
Copy link
Member

Good find @ta264 please let us know how your build goes. looking forward to the results

@hgy59 Looks good to me.

hgy59 added 2 commits August 5, 2022 23:08
- update dotnet-runtime
- use DOTNET_UNSUPPORTED_ARCHS to exclude unsupported archs from packages
@hgy59 hgy59 force-pushed the dotnet-runtime_unsupported_archs branch from bdf1422 to 5e92038 Compare August 5, 2022 21:56
@publicarray
Copy link
Member

Since .net 6.0 raised the required system libs versions, you can basically drop all of DSM 6 support and comcerto, unfortunately. AFAIK, only DSM7.0 and above contains the libraries necessary. (@ta264 https://discord.com/channels/732558169863225384/905064261984845836/1004134443755241582)

@publicarray
Copy link
Member

publicarray commented Aug 5, 2022

Thanks @hgy59, for compiling the unsupported arches, unfortunately I think this information is only valid for .NET 5.x. In.NET 6.x support is worse 😢

@publicarray publicarray added the dotnet Related to dotnet (core) label Aug 6, 2022
@hgy59 hgy59 merged commit ffd0e74 into SynoCommunity:master Dec 18, 2022
@hgy59 hgy59 deleted the dotnet-runtime_unsupported_archs branch December 18, 2022 17:19
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Dec 18, 2022
@mreid-tt mreid-tt mentioned this pull request Feb 10, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Related to dotnet (core) framework status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants