-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prowlarr v0.4.10.2111 #5400
Conversation
@wkobiela we don't create new packages for packages that use an internal updater. ( Exceptions of this rule are:
So my proposal for prowlarr:
|
It seems that prowlarr is already using alternate TMP dir: https://github.com/SynoCommunity/spksrc/blame/master/spk/prowlarr/Makefile#L38 |
@hgy59 do I also need to add |
This doesn't make any sense for the *arrs. So you're saying SynoComm policy is that the *arrs packages should never be updated? That means users will always have problems when they reinstall or uninstall and reinstall without purging existing app data. the old versions that SynoComm provides are not compatible with the new databases and thus the apps will fail to function and users must manually purge their data which is a complicated task for some users so are there no plans to land this PR then? |
OP - FYI PR is conflicted |
May as well update this to 0.4.7 rather than having it be an older version. |
And may as well Bump to 0.4.8 as .2016 had Cardigann issues. Or just land as is and follow up with the updater rework and bump there |
- update Prowlarr to v0.4.9.2083 - avoid Prowlarr downgrade on package update - move config.xml in package to the right place to avoid extra code in service-setup.sh - unfortunately the update_required file is not evaluated by Prowlarr
@bakerboy448 the automatic update on service start does not work in Prowlarr (it does work in Lidarr). |
@wkobiela I did some rework. Except the automatic update after package installation or package update, everything seems to be ok. |
@wkobiela as we now have the latest version in the package, you cannot see any update in Powlarr. The automatic update at startup will only work, when there is a version available, that has fixed this and you manually updated to such a version (or we include the fixed version in the package). But first we need the confirmation that this will be fixed. |
As Prowlarr/Prowlarr#1199 is fixed now, we only need to wait for a new release of Prowlarr. |
@wkobiela as I explained in #5511 the automatic update will only work in the future, i.e. when you update the Version 0.4.10.2111 to a future Version. But you can verfy that the update mechanism is working. When you install v0.4.10.2111 again (over 0.4.10.2111) and the update_required file in the config folder is gone after this "update" than it will work with future versions too. |
Okay, verified and it is working as you said. Auto update mechanism looks to be working |
Description
Update prowlarr - v0.4.10.2111
Checklist
all-supported
completed successfullyType of change
Tested on DSM7 on virtualDSM and both fresh install and upgrade works fine