Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prowlarr v0.4.10.2111 #5400

Merged
merged 20 commits into from
Dec 18, 2022
Merged

Conversation

wkobiela
Copy link
Contributor

@wkobiela wkobiela commented Aug 21, 2022

Description

Update prowlarr - v0.4.10.2111

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested

Type of change

  • Package update

Tested on DSM7 on virtualDSM and both fresh install and upgrade works fine

@hgy59
Copy link
Contributor

hgy59 commented Aug 21, 2022

@wkobiela we don't create new packages for packages that use an internal updater. (SPK_VERS = $(shell date +%Y%m%d) shows that the package is not bound to a specific version, as it uses an internal updater).

Exceptions of this rule are:

  • when the internal updater does not work anymore due to new dependencies
  • when new archs are added that are not included in the released packages
  • the DSM service integration needs an update (folders, user, port, etc.)

So my proposal for prowlarr:

@wkobiela
Copy link
Contributor Author

It seems that prowlarr is already using alternate TMP dir: https://github.com/SynoCommunity/spksrc/blame/master/spk/prowlarr/Makefile#L38

@wkobiela
Copy link
Contributor Author

@hgy59 do I also need to add UNSUPPORTED_ARCHS line in spk/prowlarr/Makefile? I've seen it in Radarr files and also in Jellyfin

@bakerboy448
Copy link

we don't create new packages for packages that use an internal updater.

This doesn't make any sense for the *arrs.

So you're saying SynoComm policy is that the *arrs packages should never be updated? That means users will always have problems when they reinstall or uninstall and reinstall without purging existing app data.

the old versions that SynoComm provides are not compatible with the new databases and thus the apps will fail to function and users must manually purge their data which is a complicated task for some users

so are there no plans to land this PR then?

@bakerboy448
Copy link

OP - FYI PR is conflicted

@bakerboy448
Copy link

May as well update this to 0.4.7 rather than having it be an older version.
https://github.com/Prowlarr/Prowlarr/releases

spk/prowlarr/Makefile Outdated Show resolved Hide resolved
@bakerboy448
Copy link

And may as well Bump to 0.4.8 as .2016 had Cardigann issues. Or just land as is and follow up with the updater rework and bump there

- update Prowlarr to v0.4.9.2083
- avoid Prowlarr downgrade on package update
- move config.xml in package to the right place to avoid extra code in service-setup.sh
- unfortunately the update_required file is not evaluated by Prowlarr
@hgy59
Copy link
Contributor

hgy59 commented Nov 15, 2022

@bakerboy448 the automatic update on service start does not work in Prowlarr (it does work in Lidarr).
I have created an issue there (Prowlarr/Prowlarr#1199)

@hgy59
Copy link
Contributor

hgy59 commented Nov 15, 2022

@wkobiela I did some rework. Except the automatic update after package installation or package update, everything seems to be ok.
Can you have a look at it?

@wkobiela
Copy link
Contributor Author

On first install:
image
image

On upgrade:
image
image

After manual update inside Prowlarr:
image

@hgy59
Copy link
Contributor

hgy59 commented Nov 15, 2022

@wkobiela as we now have the latest version in the package, you cannot see any update in Powlarr.
You only see the file /var/packages/prowlarr/var/.config/Prowlarr/update_required that is not deleted as service start.

The automatic update at startup will only work, when there is a version available, that has fixed this and you manually updated to such a version (or we include the fixed version in the package).

But first we need the confirmation that this will be fixed.

@hgy59
Copy link
Contributor

hgy59 commented Nov 26, 2022

As Prowlarr/Prowlarr#1199 is fixed now, we only need to wait for a new release of Prowlarr.

@wkobiela wkobiela changed the title Update Prowlarr v0.4.4.1947 Update Prowlarr v0.4.10.2111 Dec 11, 2022
@wkobiela
Copy link
Contributor Author

Configured automatic update and updated package manually, still on last version
image

@hgy59
Copy link
Contributor

hgy59 commented Dec 11, 2022

@wkobiela as I explained in #5511 the automatic update will only work in the future, i.e. when you update the Version 0.4.10.2111 to a future Version.

But you can verfy that the update mechanism is working. When you install v0.4.10.2111 again (over 0.4.10.2111) and the update_required file in the config folder is gone after this "update" than it will work with future versions too.

@wkobiela
Copy link
Contributor Author

Okay, verified and it is working as you said. Auto update mechanism looks to be working

@hgy59 hgy59 merged commit e430c85 into SynoCommunity:master Dec 18, 2022
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Dec 18, 2022
@wkobiela wkobiela deleted the prowlarr_update branch January 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants