Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross-cc.mk: Msg. to run make setup first when using all-supported #5995

Merged
merged 1 commit into from
Jan 28, 2024
Merged

cross-cc.mk: Msg. to run make setup first when using all-supported #5995

merged 1 commit into from
Jan 28, 2024

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jan 28, 2024

Description

cross-cc.mk: Echo an error message indicating to first run make setup when using make all-supported from cross

Fixes #5994

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this Jan 28, 2024
@th0ma7 th0ma7 merged commit 5bf0ab5 into SynoCommunity:master Jan 28, 2024
1 check passed
@th0ma7 th0ma7 deleted the cross-cc-error branch January 28, 2024 14:54
@mreid-tt
Copy link
Contributor

hey @th0ma7, is it possible this change is slowing down the build process? I was looking at builds for #5992 which two days ago took a matter of minutes and now they take over an hour with most of the time spent on "Evaluating dependencies". Let me know your thoughts.

th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Jan 29, 2024
@th0ma7
cross-cc.mk: Fix slowness noticed by @mreid-tt since previous fix
e9e02e2 
Ref: SynoCommunity#5995 (comment)
@th0ma7 th0ma7 mentioned this pull request Jan 29, 2024
Closed
10 tasks
mreid-tt added a commit to mreid-tt/spksrc that referenced this pull request Jan 29, 2024
@mreid-tt
Squashed commit of the following:
d5d752d 
commit e9e02e2
Author: Vincent Fortier <th0ma7@gmail.com>
Date:   Mon Jan 29 17:48:50 2024 +0000

    cross-cc.mk: Fix slowness noticed by @mreid-tt since previous fix

    Ref: SynoCommunity#5995 (comment)
@th0ma7 th0ma7 restored the cross-cc-error branch January 31, 2024 12:01
@th0ma7 th0ma7 mentioned this pull request Jan 31, 2024
Merged
@th0ma7 th0ma7 deleted the cross-cc-error branch February 1, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@th0ma7 th0ma7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when invoking build from cross
2 participants
@th0ma7 @mreid-tt