Skip to content

Commit

Permalink
fix: GITHUB_ => GH_ + linting
Browse files Browse the repository at this point in the history
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
  • Loading branch information
drptbl committed Oct 30, 2022
1 parent f0ff8a8 commit 37f34fd
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 8 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,11 @@ following features:
- [playwright debugger](https://playwright.dev/docs/debug)
- slow down tests

You may encounter 403 errors (on shared IPs & CI) related to rate limiting while fetching metamask releases from GitHub REST API. This should never happen at all, but it's good to mention. To prevent it from happening, you can create new private access token on GitHub (without any additional access) and specify `GITHUB_USERNAME` & `GITHUB_PAT` environmental variables.
You may encounter 403 errors (on shared IPs & CI) related to rate limiting while
fetching metamask releases from GitHub REST API. This should never happen at
all, but it's good to mention. To prevent it from happening, you can create new
private access token on GitHub (without any additional access) and specify
`GH_USERNAME` & `GH_PAT` environmental variables.

## 🐳 Using with Docker

Expand Down
5 changes: 3 additions & 2 deletions docker-compose.ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ services:
bash -c 'echo -n "======> local noVNC URL:
http://localhost:8080/vnc.html?autoconnect=true " && npx wait-on
http://display:8080 && echo -n "======> remote noVNC URL: " && curl -s
ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && yarn test:e2e:anvil'
ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && yarn
test:e2e:anvil'
networks:
- x11

Expand Down Expand Up @@ -69,7 +70,7 @@ services:
foundry:
container_name: foundry
image: synthetixio/foundry:016121eafdfff448414894d0ca5a50b1d72b62eb-base
command: [ 'anvil --fork-url ${ANVIL_FORK_URL}' ]
command: ['anvil --fork-url ${ANVIL_FORK_URL}']
ports:
- '8545:8545'
networks:
Expand Down
5 changes: 3 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ services:
bash -c 'echo -n "======> local noVNC URL:
http://localhost:8080/vnc.html?autoconnect=true " && npx wait-on
http://display:8080 && echo -n "======> remote noVNC URL: " && curl -s
ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && yarn test:e2e:anvil'
ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && yarn
test:e2e:anvil'
networks:
- x11

Expand Down Expand Up @@ -64,7 +65,7 @@ services:
foundry:
container_name: foundry
image: synthetixio/foundry:016121eafdfff448414894d0ca5a50b1d72b62eb-base
command: [ 'anvil --fork-url ${ANVIL_FORK_URL}' ]
command: ['anvil --fork-url ${ANVIL_FORK_URL}']
ports:
- '8545:8545'
networks:
Expand Down
6 changes: 3 additions & 3 deletions helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ module.exports = {

try {
if (version === 'latest' || !version) {
if (process.env.GITHUB_USERNAME && process.env.GITHUB_PAT) {
if (process.env.GH_USERNAME && process.env.GH_PAT) {
response = await axios.get(
'https://api.github.com/repos/metamask/metamask-extension/releases',
{
auth: {
username: process.env.GITHUB_USERNAME,
password: process.env.GITHUB_PAT,
username: process.env.GH_USERNAME,
password: process.env.GH_PAT,
},
},
);
Expand Down

0 comments on commit 37f34fd

Please sign in to comment.