feat: wait for loadingspinner to be gone (+ load states)

Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Synthetixio · Oct 30, 2022 · a3ed516 · a3ed516
1 parent 5780d84
commit a3ed516
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/commands/playwright.js b/commands/playwright.js
@@ -1,5 +1,8 @@
 const fetch = require('node-fetch');
 const { chromium } = require('@playwright/test');
+const {
+  notificationPageElements,
+} = require('../pages/metamask/notification-page');
 const sleep = require('util').promisify(setTimeout);
 
 let browser;
@@ -113,7 +116,17 @@ module.exports = {
     for (const page of pages) {
       if (page.url().includes('notification')) {
         await page.bringToFront();
+        await page.waitForLoadState('load');
+        await page.waitForLoadState('domcontentloaded');
         await page.waitForLoadState('networkidle');
+        const loadingSpinner = await page.$(
+          notificationPageElements.loadingSpinner,
+        );
+        if (loadingSpinner) {
+          await page.waitForSelector(notificationPageElements.loadingSpinner, {
+            hidden: true,
+          });
+        }
         metamaskNotificationWindow = page;
         retries = 0;
         return page;