fix: fixed metamask commands to support v11.15.5 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub <ci@drptbl.dev>
fix: fixed metamask commands to support v11.15.5
|
@fullstackninja864 is attempting to deploy a commit to the Synpress Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: drptbl <jakub.mucha@icloud.com>
Signed-off-by: drptbl <jakub.mucha@icloud.com>
|
@drptbl we need this PR to be merged ASAP, e2e stopped working because the new version of google chrome 125 is not compatible with metamask 10.25.0 |
This pull request is not working. Tests are failing. |
|
Fixing it, Thankyou for pointing out |
|
@drptbl Can you review the changes |
Signed-off-by: r3kt.eth <so@r3kt.io>
Signed-off-by: r3kt.eth <so@r3kt.io>
drptbl
added a commit
that referenced
this pull request
May 28, 2024
* Remove leftover TODOs * Remove text based locators * Add `Known problems with MetaMask` section * Remove Promise wrap from `cy.setupMetamask()` (#927) * Fix localized Chrome's extension id (#928) * Fix localized Chrome's extension id * Improve id handling --------- Co-authored-by: Piotr Frankowski <piotr@f-dev.io> * Lint * Feature/revoke permission to all (#932) * Fix typo in Permission word * Add permission revoking actions * Add tests for permission revoking actions * Regenerate synpress commands file * Add `switchNetwork` option to `acceptAccess` function * Add new release section to README * Use `goerli` for testing (#1082) * Use `goerli` for testing * Trigger tests * Add `shouldWaitForPopupClosure` option to approvals and txs (#1081) * fix: fixed metamask commands to support v11.15.5 (#1132) * release: v3.7.2-beta.9 Signed-off-by: Jakub <ci@drptbl.dev> * feature: updated lib to support metamask 11.15.5 version * use latest pnpm Signed-off-by: drptbl <jakub.mucha@icloud.com> * update metamask version Signed-off-by: drptbl <jakub.mucha@icloud.com> * added packageManager in package.json * textcase fix * click on proceedAnyway Signed-off-by: r3kt.eth <so@r3kt.io> * add pnpm Signed-off-by: r3kt.eth <so@r3kt.io> * version update Signed-off-by: r3kt.eth <so@r3kt.io> --------- Signed-off-by: Jakub <ci@drptbl.dev> Signed-off-by: drptbl <jakub.mucha@icloud.com> Signed-off-by: r3kt.eth <so@r3kt.io> Co-authored-by: Jakub <ci@drptbl.dev> Co-authored-by: Harsh Rathi <harsh@FV3P2P7KXV.local> Co-authored-by: drptbl <jakub.mucha@icloud.com> Co-authored-by: r3kt.eth <so@r3kt.io> --------- Signed-off-by: Jakub <ci@drptbl.dev> Signed-off-by: drptbl <jakub.mucha@icloud.com> Signed-off-by: r3kt.eth <so@r3kt.io> Co-authored-by: duckception <spidiritsu@gmail.com> Co-authored-by: Peter F <pietras93@gmail.com> Co-authored-by: Piotr Frankowski <piotr@f-dev.io> Co-authored-by: Rafał Majchrzak <rafal2228@gmail.com> Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com> Co-authored-by: Harsh Rathi <harsh@FV3P2P7KXV.local> Co-authored-by: r3kt.eth <so@r3kt.io>
|
Hey @fullstackninja864, thanks for your awesome work here. There are still small things to fix, but it's working. Please get in touch with me on Telegram for a small bounty for your work (@drptbl). Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Current version of synpress was missing some commands to setup latest metamask v11.15.5.
In this PR we have fixed First time flow, Main page, Notification and setting page selectors.
Does it fix any issue?
#(issue)
Other useful info
N/A
Quality checklist