Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Cypress integration with EthereumWalletMock #1133

Merged
merged 8 commits into from
May 29, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented May 22, 2024

Motivation and context

Basic for the Cypress integration with EthereumWalletMock

Does it fix any issue?

https://linear.app/synpress/issue/SYN-82/align-draft-cypress-implementation-with-the-new-plugin-architecture

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 4:36pm

return
}

if (ethereumWalletMock) return ethereumWalletMock

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'ethereumWalletMock' always evaluates to true.
@matstyler matstyler changed the title Feat/cypress integration ✨ feat: Cypress integration with EthereumWalletMock May 23, 2024
@matstyler matstyler marked this pull request as ready for review May 23, 2024 15:49
@graphite-app graphite-app bot requested a review from drptbl May 23, 2024 15:49
Copy link

graphite-app bot commented May 23, 2024

Graphite Automations

"Assign drptbl as reviewer" took an action on this PR • (05/23/24)

1 reviewer was added and 1 assignee was added to this PR based on 's automation.

@drptbl drptbl merged commit 85ba843 into new-dawn May 29, 2024
11 checks passed
@drptbl drptbl deleted the feat/cypress-integration branch May 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants