Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add phantom support #1167

Closed
wants to merge 19 commits into from

Conversation

Seroxdesign
Copy link
Contributor

Motivation and context

Add a new package for Phantom

Does it fix any issue?

SYN-127

Other useful info

New NPM package allowing users to run e2e tests with Phantom wallet

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 3:48pm

Comment on lines 47 to 51
downloadResult = await download(extensionConfig.downloadUrl, cacheDirPath, {
headers: {
Accept: 'application/octet-stream',
},
});

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The value assigned to downloadResult here is unused.
@Seroxdesign
Copy link
Contributor Author

  • Currently figuring out some specifics around unpacking and caching CRX since Phantom install doesn't have a zip option nor Github
  • Got most of the difficult bits out the way all that remains is the slow tedious work of adapting tests

@Seroxdesign Seroxdesign marked this pull request as ready for review July 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant