Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ chore: Commands refactor with a few Metamask heleprs #1205

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented Aug 20, 2024

Motivation and context

  1. Added a few Metamask helpers to the Cypress commands:
  • metamask.confirmTransactionAndWaitForMining()
  • metamask.openTransactionDetails(0)
  • metamask.closeTransactionDetails()
  1. Refactored all the Cypress commands to make it clean.

Does it fix any issue?

https://linear.app/synpress/issue/SYN-133/make-it-possible-to-close-transaction-details

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 7:40pm

@matstyler matstyler changed the title chore: commands refactor with a few Metamask heleprs ✨ chore: Commands refactor with a few Metamask heleprs Aug 20, 2024
@drptbl drptbl merged commit 9f7d994 into new-dawn Aug 21, 2024
9 checks passed
@drptbl drptbl deleted the chore/commands-refactor branch August 21, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants