-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote dev to master (3.0.0) #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
feat: improve notification window stability
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
feat: improve waiting and stability
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
console.log( | ||
'[disconnectWalletFromAllDapps] Wallet is connected to dapps, disconnecting..', | ||
); | ||
// eslint-disable-next-line no-unused-vars | ||
for (const trashButton of trashButtons) { | ||
for (const disconnectLabel of disconnectLabels) { |
Check failure
Code scanning / CodeQL
Unused loop iteration variable
For loop variable disconnectLabel is not used in the loop body.
console.log( | ||
'[disconnectWalletFromAllDapps] Wallet is connected to dapps, disconnecting..', | ||
); | ||
// eslint-disable-next-line no-unused-vars | ||
for (const trashButton of trashButtons) { | ||
for (const disconnectLabel of disconnectLabels) { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Unused variable disconnectLabel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes related with metamask@10+ update:
cy.confirmMetamaskTransaction({gasLimit: value, baseFee: value, priorityFee: value})
rinkeby
,kovan
,ropsten
(you can still add them manually)goerli
is now used as default networkLast synpress version working with metamask@9 is
2.4.1
.Synpress@3+ works only with metamask@10+.