Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API to cancel MetaMask access request (cy.rejectMetamaskAccess()) #676

Merged
merged 14 commits into from
May 14, 2023
Merged

Add new API to cancel MetaMask access request (cy.rejectMetamaskAccess()) #676

merged 14 commits into from
May 14, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Mar 9, 2023

No description provided.

@neuodev neuodev requested a review from drptbl March 9, 2023 15:32
@cypress
Copy link

cypress bot commented Mar 9, 2023 •
edited
Loading

Passing run #301 ↗︎

0 159 12 0 Flakiness 0

Details:

Add new API to cancel MetaMask access request (`cy.cancelMetamaskAcess()`)
Project: synpress Commit: 1e0896ba99
Status: Passed Duration: 14:24 💡
Started: May 14, 2023 6:58 PM Ended: May 14, 2023 7:13 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

drptbl
drptbl requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@drptbl drptbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some issue in package.json file (scripts section) after changes which breaks CI. Probably a typo or something.

@neuodev neuodev force-pushed the ahmed/cancel-mm-access branch from 37d7b90 to b216b80 Compare March 9, 2023 20:28
@neuodev
Copy link
Contributor Author

neuodev commented Mar 9, 2023

There is some issue in package.json file (scripts section) after changes which breaks CI. Probably a typo or something.

Correct, I fixed it

@neuodev neuodev requested a review from drptbl March 10, 2023 03:18
@neuodev neuodev self-assigned this Mar 12, 2023
@neuodev neuodev added the enhancement New feature or request label Mar 12, 2023
@r3kt-eth r3kt-eth merged commit 8fb9b6e into dev May 14, 2023
@neuodev neuodev changed the title Add new API to cancel MetaMask access request (cy.cancelMetamaskAcess()) Add new API to cancel MetaMask access request (cy.rejectMetamaskAccess()) Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drptbl drptbl Awaiting requested review from drptbl

Assignees

@neuodev neuodev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neuodev @drptbl @r3kt-eth