Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new flag to acceptAccess to sign type 4 message #738

Merged
merged 6 commits into from
May 11, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Apr 30, 2023

Motivation and context

This PR fixes the problem that happens if MM was requested to sign a type 4 message on accepting access.

#736

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

@neuodev neuodev self-assigned this Apr 30, 2023
@cypress
Copy link

cypress bot commented Apr 30, 2023

Passing run #264 ↗︎

0 147 12 0 Flakiness 0

Details:

feat: add new flag to acceptAccess to sign type 4 message
Project: synpress Commit: 64f4869c96
Status: Passed Duration: 09:35 💡
Started: May 10, 2023 9:34 AM Ended: May 10, 2023 9:44 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@neuodev neuodev requested a review from drptbl May 1, 2023 09:07
@drptbl drptbl merged commit ba9fbb0 into dev May 11, 2023
@drptbl drptbl deleted the ahmed/sign-on-connect branch May 11, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants