Idempotent Setters Only #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisekit
approved these changes
Mar 18, 2024
|
Bumping OP version resolved that CI test because it adds the |
mjlescano
force-pushed
the
idemponent-setters-only
branch
from
9bf3792 to
506b730
Compare
noisekit
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, all markets only have 1 settlement strategy, which means its been assigned to ID
0.We should be able to remove the "add" steps and hardcode this ID, such that updated settings files don't trigger new settlement strategies to be added.
Strategies can be added in the future by adding a new "set" step with ID 1, 2 ,3, etc.