Add tomls for SIP-363 base-sepolia #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyvempati
force-pushed
the
sip-363-sepolia
branch
from
cf5f3d9 to
91509bc
Compare
sunnyvempati
approved these changes
Apr 4, 2024
noisekit
reviewed
Apr 4, 2024
| fromCall.func = "owner" | ||
| func = "updatePriceData" | ||
| args = [ | ||
| "<%= settings.perpsWifMarketId %>", |
There was a problem hiding this comment.
Can we export market id with extras, use it here instead of hardcoded setting and then remove depends? On all steps
noisekit
reviewed
Apr 4, 2024
| @@ -14,7 +14,7 @@ const { wrapCollateral } = require('../../tasks/wrapCollateral'); | |||
| const { unwrapCollateral } = require('../../tasks/unwrapCollateral'); | |||
| const { syncTime } = require('../../tasks/syncTime'); | |||
|
|
|||
| const SYNTH_USDC_MAX_MARKET_COLLATERAL = 10_000_000; | |||
| const SYNTH_USDC_MAX_MARKET_COLLATERAL = 20_000_000; | |||
There was a problem hiding this comment.
When people managed to fill up 10mil wrapper? I thought we did not have free mint to avoid this...
noisekit
reviewed
Apr 4, 2024
| @@ -40,7 +40,7 @@ const { | |||
| }, | |||
| } = require('../../deployments/meta.json'); | |||
|
|
|||
| describe(require('path').basename(__filename, '.e2e.js'), function () { | |||
| describe.only(require('path').basename(__filename, '.e2e.js'), function () { | |||
There was a problem hiding this comment.
Suggested change
| describe.only(require('path').basename(__filename, '.e2e.js'), function () { | |
| describe(require('path').basename(__filename, '.e2e.js'), function () { |
noisekit
reviewed
Apr 4, 2024
| @@ -230,6 +245,11 @@ describe(require('path').basename(__filename, '.e2e.js'), function () { | |||
| settlementStrategyId, | |||
| }); | |||
|
|
|||
| const PerpsMarketProxy = new ethers.Contract( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.