Re-running the formatter #1194
Merged
Re-running the formatter #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
liamzebedee
reviewed
Apr 7, 2021
.solhint.json
Outdated
| "contract-name-camelcase": "warn", | ||
| "multiple-sends": "warn", | ||
| "reentrancy": "warn", | ||
| "max-states-count": ["warn", 17] |
There was a problem hiding this comment.
this is ["warn",15] in the new recommended ruleset, but doesn't seem to error on any of our contracts.
Codecov Report
@@ Coverage Diff @@
## develop #1194 +/- ##
========================================
Coverage 95.62% 95.62%
========================================
Files 76 76
Lines 5413 5413
Branches 661 661
========================================
Hits 5176 5176
Misses 237 237
Continue to review full report at Codecov.
|
jjgonecrypto
changed the title
eternauta1337
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
pretty-quickwas skipped during commits (perhaps via--no-verify) and some formatting omissions appeared. This PR reformats everything via annpm run format