-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(formatting): 🚀 pre-commmit,pre-commit config,import and code fixes #111
Conversation
onuralpszr
commented
Sep 22, 2023
•
edited
Loading
edited
- pre-commit added
- pre-commit config yaml added
- test fixes
- import * fixes and replace with proper import rule
- f-string usage
- isinstance usage instead of type check
- ruff added
- generic rules added (white space,end of line space etc)
- bandit added
- py38 based on rules added
- git hook ability
- fix implement flake8 #104
- fix implement isort #106
- fix Replace string.formats with f"" #74
- fix Refactoring for Formatting and Style #108
- fix implement black #105
- fix Run --help for no options #77
… req*.txt Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@fedoraproject.org>
Thanks for the pr @onuralpszr ! . Let me check pr #110 first (probably this weekend, sorry for the latency) and then checkout this one. I am a bit obsessed with formatting and I dont want to apply all the pep8 or other derived rules. Lets merge your first pr first and then I need to go over this one and we can discuss afterward. Thanks for the great work! |
95870e6
to
28da811
Compare
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
28da811
to
3780c6c
Compare
@onuralpszr you mentioned you fix this one with this PR. Since the PR is big, before my detailed look at this (and #110 should come first) can I ask where and how exactly did you solve this. I am just asking not to miss anything. |
Merge #110 and if we change something I can rebase or fix conflict in here. But if you accept "as it is" well good because I create this PR from #110. Magical solve will happen :)) |
Can you explain the |
no command gives you "help" but I guess you want "kfk command" <-- no param == shows you help ? |
Hi @onuralpszr. Would you mind separating this PR into two like 1- pre-commit and other stuff like fstring usage etc. 2- formatting So it will be a lot easier to review and discuss the changes. Would you be able to do this? If not, pls let me know so I can work on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: my comment above