docs:📝 contributing guide added #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
mabulgu
requested changes
Oct 17, 2023
There was a problem hiding this comment.
@onuralpszr If you can update the poetry relevant steps in this PR, we can merge this as well
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
mabulgu
reviewed
Feb 5, 2024
Co-authored-by: Aykut M. Bulgu <mabulgu@gmail.com>
mabulgu
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Made a few changes and removed the part which included the "poetry" I will add a part that consists of "make" and several stuff in the future. Apart from that this contribution guide was well enough to be as a starter. @onuralpszr thanks for your efforts on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix : #66
I don't know what do you think about in this one but at least it could be a good base as well.