Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scalar if conditions #54

Closed
leolitenstorrent opened this issue Jul 18, 2023 · 3 comments
Closed

Use scalar if conditions #54

leolitenstorrent opened this issue Jul 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@leolitenstorrent
Copy link

Hello Alex,

May you make the conditions for if statements scalars instead of vectors (see image below)? This has been causing Spyglass Lint to generate warning messages. Thank you!

image
@leolitenstorrent leolitenstorrent changed the title Use scalar conditions Use scalar if conditions Jul 18, 2023
@amykyta3 amykyta3 added feature request New feature or request bug Something isn't working and removed feature request New feature or request labels Jul 19, 2023
@amykyta3
Copy link
Member

Will do. In this case, I can change the ^ to != for equivalent behavior.

Is this the only situation where this type of warning was flagged?

amykyta3 added a commit that referenced this issue Jul 19, 2023
@amykyta3
Make stickybit conditional predicate a single-bit result rather than …
18f8f35 
…a vector. #54
@leolitenstorrent
Copy link
Author

leolitenstorrent commented Jul 19, 2023 •
edited
Loading

Hello,

Thank you! I remember this type of waring is also flapped for the interrupt capture conditions of other interrupt register types.

image image image

amykyta3 added a commit that referenced this issue Jul 20, 2023
@amykyta3
Make remaining interrupt conditional predicates single-bit. #54
da8ff4a
@amykyta3
Copy link
Member

Thanks. Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amykyta3 @leolitenstorrent