Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CPUIFs to have parameters #80

Closed
wants to merge 3 commits into from

Conversation

hughjackson
Copy link
Contributor

@hughjackson hughjackson commented Jan 4, 2024

Expose a method to allow custom CPUIFs (and any new internal ones) to use parameters (for example to size sideband signals that do not directly get consumed by the regblock logic but pass from request to response). This has been tested with a custom interface but may need additional unit testing adding

@amykyta3
Copy link
Member

amykyta3 commented Jan 6, 2024

Thanks!
I can see how this is useful.

I'm going to hold off on merging this at the moment since I may end up restructuring this slightly. I'm not too keen on having the parameter_declaration property be a naive singular string - I think it should be more structured to allow better scalability if I find other reasons to insert parameters elsewhere.

Will keep it as a reference for now.

amykyta3 added a commit that referenced this pull request Mar 30, 2024
@amykyta3
Copy link
Member

Implemented an alternate but very similar solution which will be in the upcoming release.

Rather than providing the full string, the cpuif base class provides a list of strings, one for each parameter. For example:

    @property
    def parameters(self):
        return [
            "parameter FOO = 1",
            "parameter BAR = 2",
        ]

Thanks for the idea!

@amykyta3 amykyta3 closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants