Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting battery level also in hid, if it was created, yet #13

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

grafmar
Copy link
Contributor

@grafmar grafmar commented Feb 12, 2020

  • To be able to update the batteryLevel of the HID, it has to call the setBatteryLevel() method of the HID
  • removed unused buttons member and method

removed unused buttons member and method
@T-vK
Copy link
Owner

T-vK commented Feb 12, 2020

Hey, thanks for the contribution. Have you tested the code? I couldn't get it to display the battery level on an Android 9 phone with your code.
I tried calling bleKeyboard.setBatteryLevel(50); in both the setup function as well as in the loop function without any luck.

@grafmar
Copy link
Contributor Author

grafmar commented Feb 13, 2020 via email

@T-vK
Copy link
Owner

T-vK commented Feb 13, 2020

Okay, I have verified this now. I'll merge this PR and hopefully create a new release later today.
This PR fixes #8.

@T-vK T-vK merged commit d0e286d into T-vK:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants