F-Droid can't build

[licaon-kter]

...reproducible

ref: https://monitor.f-droid.org/builds/log/ru.tech.imageresizershrinker/45#site-footer

[T8RIN]

What's went wrong?

[T8RIN]

I'm still using github actions(

[licaon-kter]

46 built fine: https://monitor.f-droid.org/builds/log/ru.tech.imageresizershrinker/46#site-footer 🎉

[licaon-kter]

And again https://monitor.f-droid.org/builds/log/ru.tech.imageresizershrinker/66#site-footer :(

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/2ee4d8e8ae8e9486ca3237fbc30c2c636fe164c6

[linsui]

How did you build it? From which commit?

[T8RIN]

Just used this https://github.com/awxkee/avif-coder

[linsui]

They doesn't provide build script either. Only binaries...

[T8RIN]

I see, i think they needed to be compiled using C ides, so AS cant do that

[T8RIN]

@linsui @licaon-kter is now the app can be published again?

[shuvashish76]

Any updates? Missing multiple releases 😶‍🌫️

[T8RIN]

Unfortunately no :( i don't know how to add those libs to gradle to be built automatically, because those libs are compiled from non android cpp code

[linsui]

I thought the proper way is using cmake but you can add a build script and run it in gradle.

[IzzySoft]

Btw, build of 2.3.0 will fail, too, see #412

[T8RIN]

@licaon-kter hi, how to update yml according to #412 ?

[T8RIN]

Didn't get it about avif, can you reexplain please? :(

[licaon-kter]

OK, so, your FOSS APKs use "random" libs from the internet: https://github.com/T8RIN/ImageToolbox/tree/47af5c6b0742748100fc6c4cb8aedc4b0d4837bb/avif-coder/src/main/cpp/lib/arm64-v8a

We need to rebuild them (see recipe above) or defer to the maven uploaded ones (hopefully those are free and clean): implementation 'com.github.awxkee:avif-coder:1.0.19'

But, rebuilding them brings variability, do you build stuff under clean Debian or just use a random Mac device?

So, next move, can you use implementation 'com.github.awxkee:avif-coder:1.0.19' ?

[T8RIN]

Hmm, i think i can use this dependency for foss flavor and my modified one for others

[T8RIN]

I spent 3 hours, but, now the foss flavor must rely on the remote avif-coder

[T8RIN]

@licaon-kter i've added remote dep in 2.3.2, so, can i be on f-droid now?

[licaon-kter]

Ok, almost there

│ │ │   --- image-toolbox-2.3.2-foss-universal/smali/ca/a.smali
│ │ ├── +++ ru.tech.imageresizershrinker_87/smali/ca/a.smali
│ │ │ @@ -9995,15 +9995,15 @@
│ │ │      .line 1560
│ │ │      .line 1561
│ │ │      invoke-virtual {v1, v0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
│ │ │  
│ │ │      .line 1562
│ │ │      .line 1563
│ │ │      .line 1564
│ │ │ -    const-string v0, " 2.3.2_foss (87)"
│ │ │ +    const-string v0, " 2.3.2-foss (87)"
...
│ │ │ │ │ │ │   --- image-toolbox-2.3.2-foss-universal/smali/ru/tech/imageresizershrinker/presentation/crash_screen/CrashActivity.smali
│ │ │ │ │ │ ├── +++ ru.tech.imageresizershrinker_87/smali/ru/tech/imageresizershrinker/presentation/crash_screen/CrashActivity.smali
│ │ │ │ │ │ │ @@ -279,15 +279,15 @@
│ │ │ │ │ │ │      .line 115
│ │ │ │ │ │ │      .line 116
│ │ │ │ │ │ │      invoke-static {v8, v2, v1, v3, p1}, Lo/h;->J(Ljava/lang/StringBuilder;Ljava/lang/String;Ljava/lang/String;ILjava/lang/String;)V
│ │ │ │ │ │ │  
│ │ │ │ │ │ │      .line 117
│ │ │ │ │ │ │      .line 118
│ │ │ │ │ │ │      .line 119
│ │ │ │ │ │ │ -    const-string p1, "), App: 2.3.2_foss (87)\n\n"
│ │ │ │ │ │ │ +    const-string p1, "), App: 2.3.2-foss (87)\n\n"
...
│ │ │ │ │ │ │ │   --- image-toolbox-2.3.2-foss-universal/smali/ru/tech/imageresizershrinker/presentation/main_screen/viewModel/MainViewModel.smali
│ │ │ │ │ │ │ ├── +++ ru.tech.imageresizershrinker_87/smali/ru/tech/imageresizershrinker/presentation/main_screen/viewModel/MainViewModel.smali
│ │ │ │ │ │ │ │ @@ -397,15 +397,15 @@
│ │ │ │ │ │ │ │  
│ │ │ │ │ │ │ │      .line 16
│ │ │ │ │ │ │ │      .line 17
│ │ │ │ │ │ │ │      .line 18
│ │ │ │ │ │ │ │      move-result v1
│ │ │ │ │ │ │ │  
│ │ │ │ │ │ │ │      .line 19
│ │ │ │ │ │ │ │ -    const-string v2, "2.3.2_foss"
│ │ │ │ │ │ │ │ +    const-string v2, "2.3.2-foss"
...
│ │ │   --- image-toolbox-2.3.2-foss-universal/smali/ua/u1.smali
│ │ ├── +++ ru.tech.imageresizershrinker_87/smali/ua/u1.smali
│ │ │ @@ -506,15 +506,15 @@
│ │ │  
│ │ │      .line 203
│ │ │      .line 204
│ │ │      .line 205
│ │ │      move-result-object v16
│ │ │  
│ │ │      .line 206
│ │ │ -    const-string v17, "2.3.2_foss (87)"
│ │ │ +    const-string v17, "2.3.2-foss (87)"

while the source code has suffix -foss and F-Droid builds that: https://github.com/T8RIN/ImageToolbox/blob/2.3.2/app/build.gradle.kts#L68

Your hosted APKs have _foss ? @T8RIN https://github.com/T8RIN/ImageToolbox/releases/tag/2.3.2

[T8RIN]

🐸❤️

[T8RIN]

@licaon-kter also when it will be available at the f-droid?👀

[licaon-kter]

@T8RIN https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client

[linsui]

It's available now.

[T8RIN]

Great!

[T8RIN]

@licaon-kter hi, i noticed, that for some reason new fastlane screenshots and description doesn't appear on the f-droid app page, at least on the site, what's went wrong here? :(

[licaon-kter]

you had 2 JPG files(811c858#diff-0e01beb746633e7827aeac7c5376452173f6274899f081a4de077f30540b63b0), you deleted and replaced them with PNGs

known issue, fdroidserver didn't clean up: https://gitlab.com/fdroid/fdroidserver/-/issues/490 :(

will try a manual clean up next: https://gitlab.com/fdroid/admin/-/issues/377#note_1665510324

[T8RIN]

you had 2 JPG files(811c858#diff-0e01beb746633e7827aeac7c5376452173f6274899f081a4de077f30540b63b0), you deleted and replaced them with PNGs

known issue, fdroidserver didn't clean up: https://gitlab.com/fdroid/fdroidserver/-/issues/490 :(

will try a manual clean up next: https://gitlab.com/fdroid/admin/-/issues/377#note_1665510324

Okay, i'll wait...

[T8RIN]

Hi, @licaon-kter , why 2.6.0 isn't available on fdroid yet?

[T8RIN]

I see something with native libs

[linsui]

As I guess, the ndk build id is different. Please disable ndk build id for libWatermark.so. See https://f-droid.org/docs/Reproducible_Builds/#ndk-build-id.

[T8RIN]

Okay, i will try to do so, anyway idk why watermark have own cpp file, it's not used as i remember

[T8RIN]

Added this, hope it will help

[linsui]

Thanks! Let's see if the next version is reproducible.

[T8RIN]

@linsui, @licaon-kter how it's going on 2.6.1-alpha01 ? 👀

[T8RIN]

If you can, it will be good to push 2.6.0-alpha01 at least 👀

[licaon-kter]

done https://gitlab.com/fdroid/fdroiddata/-/commit/072fca4258c941b7c60efd76fc57205de84070e8

[T8RIN]

@licaon-kter i pushed stable release, hope it will be available on f-droid

[linsui]

It builds in the CI.

[T8RIN]

Okay

[T8RIN]

@IzzySoft @licaon-kter is this library can be integrated into my app and published on f-droid?

https://developers.google.com/ml-kit/vision/doc-scanner/android?hl=ru

[IzzySoft]

MLKit is proprietary, so the answer would be a clear "No". In general: when the source code is not openly available and covered by a free/libre license, the answer is "No".

[T8RIN]

MLKit is proprietary, so the answer would be a clear "No". In general: when the source code is not openly available and covered by a free/libre license, the answer is "No".

Okie dokie

[T8RIN]

@IzzySoft And one more question, this restriction also for open source libraries that rely on proprietary libs?

Like this
https://github.com/G00fY2/quickie

[IzzySoft]

Well, guess what happens when you implement that here? Pointers:

  add("bundledImplementation", libs.mlkit.barcodeScanning)
  add("unbundledImplementation", libs.mlkit.barcodeScanningGms)

If you implement it yourself, or implement a library which implements it, or implement a library implementing a library that implements… doesn't matter. All that will end up in your APK. So yes, this restriction applies wherever proprietary pieces come in.

[T8RIN]

Thx for explaining👀

[licaon-kter]

@T8RIN https://gitlab.com/fdroid/fdroiddata/-/jobs/7259305509#L7011

maybe read https://gist.github.com/obfusk/61046e09cee352ae6dd109911534b12e

[linsui]

Where is the apk? Sort may not work, but you can disable the baseline completely. See https://gist.github.com/obfusk/61046e09cee352ae6dd109911534b12e#fix-proposed-by-linsui-disable-baseline-profiles

[T8RIN]

In actions section of the repo

[T8RIN]

Where is the apk? Sort may not work, but you can disable the baseline completely. See https://gist.github.com/obfusk/61046e09cee352ae6dd109911534b12e#fix-proposed-by-linsui-disable-baseline-profiles

Sounds not like a solution, they are enabled for a long time

[licaon-kter]

I've built 91bc53b and compared against GHA artefacts https://github.com/T8RIN/ImageToolbox/actions/runs/10073062957 and appears to be repro 🎉

[T8RIN]

Good! Gradle 8.5.2 , so maybe they fixed this