Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Suggestion #145

Closed
Iamlooker opened this issue Apr 17, 2023 · 15 comments
Closed

UX Suggestion #145

Iamlooker opened this issue Apr 17, 2023 · 15 comments
Labels
enhancement New feature or request

Comments

@Iamlooker
Copy link
Contributor

-2147483648_-210068

We shouldn't be using such a high contrast color here (especially with borders). I diverts user focus and disrupts User Flow, maybe trying a toned down color or even moving this to a seperate page would help.

@T8RIN
Copy link
Owner

T8RIN commented Apr 17, 2023

Can you do it? I would merge PR :)

@Iamlooker
Copy link
Contributor Author

Can you do it? I would merge PR :)

Sure

@Iamlooker
Copy link
Contributor Author

Well, also you downgraded gradle, is there a reason why? Maybe I can help with it

@T8RIN
Copy link
Owner

T8RIN commented Apr 17, 2023

Oh, yes, github actions can't build it with 8.0 and java 17, idk why((

@Iamlooker
Copy link
Contributor Author

Maybe some jdk distribution issue, you can try adopt instead of temurin. Or you can check this workflow here

@Iamlooker
Copy link
Contributor Author

Just one question, do we really need this bottom app bar?
I mean everything like that is available in settings sheet.

@T8RIN
Copy link
Owner

T8RIN commented Apr 17, 2023

Yup 👀

@T8RIN
Copy link
Owner

T8RIN commented Apr 17, 2023

@Iamlooker
Copy link
Contributor Author

T8RIN/ImageResizer/actions/runs/4719862251

Still fails(

Ohh, that seems like a issue with new full-mode R8 to me, but I am not sure. I will look into it and notify you once I find a fix

@T8RIN
Copy link
Owner

T8RIN commented Apr 17, 2023

Thanks!

@T8RIN T8RIN added the enhancement New feature or request label Apr 17, 2023
@Iamlooker
Copy link
Contributor Author

Iamlooker commented Apr 19, 2023

I think you can simply follow this path while building locally and you can add these to proguard-rules

ImageResizer/ImageResizer/app/build/outputs/mapping/release/missing_rules.txt

T8RIN added a commit that referenced this issue Apr 19, 2023
@T8RIN
Copy link
Owner

T8RIN commented Apr 19, 2023

i hope it hleps...

T8RIN added a commit that referenced this issue Apr 19, 2023
@T8RIN
Copy link
Owner

T8RIN commented Apr 19, 2023

It works! Thanks 👍
https://github.com/T8RIN/ImageResizer/actions/runs/4740820377

@T8RIN
Copy link
Owner

T8RIN commented Apr 19, 2023

Can we close the issue now? 👀

@Iamlooker
Copy link
Contributor Author

Sure 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants