Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended Second Rotation Occurs After Freehand Crop, Causing Distortion #1572

Closed
maninthemiddle01 opened this issue Jan 5, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@maninthemiddle01
Copy link

When an image is rotated once by 90° and then cropped with the freehand tool, the application automatically applies a second rotation without user input. This unintended rotation occurs within the old rotated bounding box, resulting in a distorted or “squeezed” final image.


Steps to Reproduce:

  1. Open any image.
  2. Rotate the image by 90°.
  3. Crop the image using the freehand tool.
  4. Observe that the image appears to be rotated again automatically (no user-initiated second rotation).
  5. The final result is a squeezed or distorted image confined to the previously rotated bounding box.

Expected Behavior:

Only one rotation should remain in effect. After a freehand crop, the image should maintain its cropped dimensions and orientation without any additional, automatic rotation.

Actual Behavior:

The application applies a second rotation automatically within the initially rotated bounding box, leading to a visibly distorted image.

Environment:

  • ImageToolbox: 3.1.1-foss (161)
  • OS: 21-20241211-NIGHTLY-a52sxq
  • Device: SM-A528B

Suggested Fix / Possible Cause:

  • Root Cause: The code that handles final rendering appears to be reapplying rotation logic after the freehand crop action.
  • Fix: Ensure the post-crop process correctly resets or preserves the intended (single) rotation state, so the image is not rotated again without user instruction.
@maninthemiddle01 maninthemiddle01 added the bug Something isn't working label Jan 5, 2025
@T8RIN
Copy link
Owner

T8RIN commented Jan 5, 2025

could you record a video please?

@T8RIN
Copy link
Owner

T8RIN commented Jan 5, 2025

because work normal for me

@maninthemiddle01
Copy link
Author

i hope this helps. Also the saved image has the dimensions of the preview image
final

@T8RIN
Copy link
Owner

T8RIN commented Jan 6, 2025

Oh, I got it, it's not a rotation

@T8RIN T8RIN closed this as completed Jan 7, 2025
@Edinho367 Edinho367 marked this as a duplicate of #1616 Jan 22, 2025
@T8RIN T8RIN marked this as not a duplicate of #1616 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants