Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: null handling in the status filter options for all admin tables #309

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Sep 6, 2024

Overview

Checks for null for filter options for listings in admin exceptions and admin extensions.

Related

WA-349

Changes

Testing

  1. Then git checkout hotfix/check-for-null-status-extension
  2. Test http://localhost:8000/administration/list-exceptions/
  3. http://localhost:8000/administration/list-extensions/

UI

@chandra-tacc chandra-tacc changed the title Hotfix/check for null status Hotfix: null handling in the status filter options for all admin tables Sep 19, 2024
threshold form
- Adds required threshold form field to write to the exception
database table
- Updates docker-compose to docker compose in Makefile
for local development
@chandra-tacc chandra-tacc force-pushed the hotfix/check-for-null-status-extension branch from a1f5912 to 3371925 Compare September 19, 2024 17:12
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested, ensured nulls are in dev db and also checked 'All' shows as the first entry.

@chandra-tacc chandra-tacc merged commit 02d179e into main Sep 19, 2024
@chandra-tacc chandra-tacc deleted the hotfix/check-for-null-status-extension branch September 19, 2024 17:34
Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR solves the NoneType-str comparison bug, but the result is that the 'None' shows up in the filter options as the first element in the dropdown, so the page shows that 'None' is the selected status filter option even though 'All' records are shown.

@chandra-tacc chandra-tacc restored the hotfix/check-for-null-status-extension branch September 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants