Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/address-null-in-filters #315

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Sep 19, 2024

Overview

Checks for null for filter options for listings in admin listing tables and user submission table.

Related

WA-349

Changes

Testing

  1. Checkout main then pull this branch
  2. Go to each listing page and make sure they're listed alphabetically and sorted correctly.
  1. Toggle filters and make sure they work correct (known race conditions if you change them too quickly before load)
  2. Review code to check for consistency and null checking

UI

Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

apcd_cms/src/apps/admin_exception/views.py Show resolved Hide resolved
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit eb46fce into main Sep 20, 2024
@chandra-tacc chandra-tacc deleted the hotfix/address-null-in-admin-filters branch September 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants