Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lccf): cleanup #343

Merged
merged 2 commits into from
Oct 31, 2024
Merged

chore(lccf): cleanup #343

merged 2 commits into from
Oct 31, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 31, 2024

Overview / Changes

  • Add commented CSS that might be used.
  • Remove unused snippets.

Related

LCCF will launch with a Portal. I will replace CSS snippets on three staging sites and current prod site with a link to this updated stylesheet.

Testing

  1. Deploy LCCF with CMS Settings

    PORTAL_STYLES = [{
        "is_remote": True,
        "path": "https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@chore/lccf-cleanup/lccf_assets/header.css",
    }]

    and Portal settings

    _PORTAL_CSS_FILENAMES = [
        "https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@chore/lccf-cleanup/lccf_assets/header.css"
    ]
  2. Verify header is tall (if stylesheet loads1).

UI

lccf CMS lccf-portal (CMS)
lccf lccf-portal

Notes

Footnotes

  1. Stylesheet is not loading on portal. That is not a bug with this PR, which is just to supply a CDN.

The code of these snippets is of an abandoned idea, even on CTRN.

The are replaced by Core-Styles Bootstrap 4 extension, `.col-dark`.
@wesleyboar wesleyboar merged commit 1773073 into main Oct 31, 2024
@wesleyboar wesleyboar deleted the chore/lccf-cleanup branch October 31, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant