Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lccf): align cms menu nav link via Core-Styles #410

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(lccf): align cms menu nav link via Core-Styles #410

merged 1 commit into from
Jan 17, 2025

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 15, 2025 •
edited
Loading

Overview

Rely on Core-Styles to fix CMS menu .nav-link alignment.

Related

Changes

  • deletes code that Core-Styles now gives
  • deletes obvious comments

Testing

  1. Deploy/Replicate on https://pprd.lccf-portal.tacc.utexas.edu/.
  2. View when navbar is expanded.
    1. Verify .nav-link underline is at bottom of header.
    2. Verify .nav-link text is vertically aligned center with search bar.
  3. View when navbar is collapsed.
    1. Verify .nav-links are not too close to each other.

UI

LCCF Custom header.css Core-Styles …header.css
lccf custom header css content core-styles header css content
lccf custom header css url core-styles header css url
mobile view
mobile view

This was referenced Jan 15, 2025
Merged
Merged
@wesleyboar wesleyboar marked this pull request as ready for review January 17, 2025 20:56
@wesleyboar wesleyboar merged commit 91804a0 into main Jan 17, 2025
@wesleyboar wesleyboar deleted the fix/lccf-cms-menu-nav-alignment-not-via-core-styles branch January 17, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar