-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-101: Environment Variables for CSS #221
Merged
wesleyboar
merged 44 commits into
task/GH-101-header-redesign
from
task/GH-101-header-redesign--env-variables
May 12, 2021
Merged
GH-101: Environment Variables for CSS #221
wesleyboar
merged 44 commits into
task/GH-101-header-redesign
from
task/GH-101-header-redesign--env-variables
May 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore missing line between search bar and portal nav - (Simplify CSS of line between search bar and portal nav) - Do not let background show through search bar. - (This happens now because of a color replacement.)
So that Portal and Docs need not reinvent the wheel.
So that Portal and Docs need not reinvent the wheel.
…gos--remove-api-solution
…ask/GH-191-support-light-navbar-for-dark-logos--remove-api-solution
Though this load would cause redundant global vars, it is explicit. A long-term solution is unclear. A worse problem exists with font.
…r-dark-logos--remove-api-solution Task/gh 191 support light navbar for dark logos remove api solution
The support required `tacc-wbomar/jsonc-require` repo. But Jenkins has credential failure if downloading from Git. Alt: My PR to aMarCruz/jsonc-require is approved and merged. Then the `.jsonc` support will be built into `json-require`. SEE: aMarCruz/jsonc-require#1
- Remove global colors import that is redundant on Portal. - Comment plan to remove global fonts redundant on Portal.
This reverts functional parts of commit 7de1751. This also tweaks comments for clarity. The code tests successfully, but… - The branding should NOT use the header nav colors. - Which—if any—global vars should become env vars? - How would we allow overwriting or extending themes?
- __New__: Ignore dynamic settings.json. - __New__: Add settings_to_json.py. - __New__: Add THEME to secrets/settings. - _Minor_: Support temp. hiding print statements. - _Major_: Import THEME from settings.json now. - _Minor_: Tweak theme.*.json files.
This was referenced May 12, 2021
wesleyboar
changed the title
Task/gh 101 header redesign env variables
GH-101: Environment Variables for CSS
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
env()
.Changes, Testing, Etc.
See #192 (as of 396c018).