Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-101: Navigation Bar (Sans Search & Portal Nav Button) #225

Commits on May 13, 2021

  1. GH-101: Navigation Bar (Partially Complete)

    - Remove now-moot taccsite_custom:frontera-cms search bar font sizes.
    - Support CSS custom selectors (known external bug).
    - Test CSS custom selectors (known external bug).
    - Remove outdated comment from `c-branding`.
    - Set `c-logo` image height in component stylesheet.
    - Add TODO for `html { font-size: 62.5%; }`
    - Add arrow "mixin" (note: using `%-arrow` syntax).
    - Redesign header (but not dropdowns and not portal nav).
    - Remove now-moot `s-portal-nav` styles.
    - Add & Update header env variables for themes.
    - Perform "GH-129: Do Not Support CMS Menu Nav Link & Dropdown".
    wesleyboar committed May 13, 2021
    Configuration menu
    Copy the full SHA
    b2cec49 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. GH-101: Navigation Bar (Fix CMS Nav Bug in Docs)

    Prevent dropdown link from being flagged as active.
    wesleyboar committed May 14, 2021
    Configuration menu
    Copy the full SHA
    a9ec66a View commit details
    Browse the repository at this point in the history
  2. GH-101: Navigation Bar (Fix Color Bug/s in Docs)

    - (Real Fix) Ensure colors are available to Docs.
    - (Possible Fix) Ensure correct colors are available to Portal.\*
    
    \* The Portal has its own settings/color.css that is almost identical.
    wesleyboar committed May 14, 2021
    Configuration menu
    Copy the full SHA
    23e3db2 View commit details
    Browse the repository at this point in the history
  3. GH-101: Navigation Bar (Fix More Bugs in Docs)

    - Load new styles solely for docs header.
    - Force branding styles on old markup.
    - Migrate subsite selectors from `trumps/s-header` to `tools/selectors`.
    - Rename `:--in-__subsite__` selectors to `:--from-__subsite__`.
    - Create new styles solely for docs header.
    - Document "For (Other Sites)" i.e. `trumps/for-docs.*.css` stylesheets.
    wesleyboar committed May 14, 2021
    Configuration menu
    Copy the full SHA
    c988a7b View commit details
    Browse the repository at this point in the history
  4. GH-101: Navigation Bar (Fix Img Max-Width in Docs)

    Unset Docs' `img { max-width; }`. Docs does this too but for old markup.
    wesleyboar committed May 14, 2021
    Configuration menu
    Copy the full SHA
    290e27b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d3361d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ccfc596 View commit details
    Browse the repository at this point in the history
  7. GH-101: Navigation Bar (Use Constants for Header)

    - Install `merge-lite` for deep merge constants and theme data.
    - Use env() vars for header height.
    - Remove unnecessary code and improve comments.
    - Create constants for theme JSON.
    - Merge constants on top of theme data.
    - Update theme data comment syntax.
    wesleyboar committed May 14, 2021
    Configuration menu
    Copy the full SHA
    ea43ec9 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. GH-101: Navigation Bar (Logo Width, CMS Nav Align)

    - Add frontera-cms logo width overwrite (temp. ineffectual, see GH-223).
    - Prevent Core (but not a project) from stretching logo too wide.
    - Align CMS nav for narrow logos. Allow project-specific adaptation.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    538369a View commit details
    Browse the repository at this point in the history
  2. GH-101: Navigation Bar (Remove Redundant Style)

    - Remove redundant color assignment for nav-link.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    f257c63 View commit details
    Browse the repository at this point in the history
  3. GH-101: Navigation Bar (Dropdowns & Constants)

    - Add font weight constants.
    - Add border constants.
    - Style dropdowns and use new constants.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4692aaf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d6c59ca View commit details
    Browse the repository at this point in the history
  5. GH-101: Navigation Bar (Fix Branding Bar Bug)

    Use correct global var not wrong env var for branding bar bkgd.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4865c2d View commit details
    Browse the repository at this point in the history
  6. GH-101: Navigation Bar (Avoid Dropdown Bug)

    Scope dropdown styles to header so as to not effect any other dropdowns.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    2ab97e8 View commit details
    Browse the repository at this point in the history
  7. GH-101: Navigation Bar (Fix .s-header Usage)

    1. Scope header-specific `.c-branding` styles with `.s-header`.
    2. Clarify which `s-header` is being styled and why.
    3. Remove `s-header` ID from sample header markup.
    4. Add `s-header` class to `header-branding`.
    5. Replace `s-header` ID with `header-navbar` ID.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    80fb36c View commit details
    Browse the repository at this point in the history
  8. GH-101: Navigation Bar (Fix Portal Menu Item Hue)

    Portal needs to overwrite Bootstrap's color for active `dropdown-item`.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    bde4dc5 View commit details
    Browse the repository at this point in the history
  9. GH-101: Navigation Bar (Use Fallbacks for Vars)

    Instead of defining a value to be overwritten, set a fallback.
    
    This reduces one level of overwrite when tracking/debugging values.
    wesleyboar committed May 17, 2021
    Configuration menu
    Copy the full SHA
    7c8846c View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. GH-101: Navigation Bar (Consistent Line-Height)

    Ensure Portal & Docs line-height (in header) matches CMS.
    wesleyboar committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5f83e6a View commit details
    Browse the repository at this point in the history
  2. GH-101: Navigation Bar (Responsive Nav Item Width)

    - The responsive space between nav items now considers portal elements.
    - Whether header is loaded on portal is noted by presence of a class.
    wesleyboar committed May 18, 2021
    Configuration menu
    Copy the full SHA
    315ac1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8936201 View commit details
    Browse the repository at this point in the history