Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Django 4 (for TUP CMS) #667

Closed
wants to merge 305 commits into from
Closed

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 5, 2023

Overview

Update Django to v4+ and bump deprecated dependencies, for tup-cms.

Status

Closed, because I updated this to mainmain branch, as of https://github.com/TACC/Core-CMS/releases/tag/v3.12.0-alpha.11, will probably crash https://github.com/TACC/tup-ui/tree/v1.0.9/apps/tup-cms.

Related

Changes

...

Testing

...

UI

...

wesleyboar and others added 30 commits December 8, 2022 16:53
- fix(icon): hide text inside icon (TACC/Core-Styles#86)
- fix(package): move npm-watch to devDeps (TACC/Core-Styles@8b2ee16)
- feat(cortal.icons): collapse alias (TACC/Core-Styles#85)
- newest cms button styles
- load cms button in new cms stylesheet
- load core button in old cms stylesheet
- avoid duplicate load of stylesheets
- `core-styles.cms.css` will load core-styles font sizes
    - core-styles@v0-only cuz `assets_core_cms.html` conditional load
- `site.css` will load core-styles font sizes
    - core-styles@v0-only cuz `assets_site.html` conditional load
It was "16px", then moved up to "18px" with font size value changes, but design wants it at "12px".
To start fresh with global Snippet styles, then move em to Core-Styles.
…Core-CMS into task/get-core-styles-beyond-0.11.0
Load core-styles.demo.css before base, just like TACC/Core-Styles.
Let cms styles be applied per pattern, like core-styles does.
- So, core-styles and core-cms demo do not differ.
- Thus, portal and cms can reliably reference demo.

A bonus is that core-styles cms and portal stylesheets are pressured be accurate.
Use new feature from Core-Styles.
Breaking Change: CMS Font sizes and names moved. Check its commit.
By building default context atop core-styles, we define less paths.
This is atop the card & section patterns I've been installing/updating.
wesleyboar and others added 23 commits June 14, 2023 17:44
* fix(css): bump text editor css core-styles to v2.9

* docs(css): reference v2.9.0 directly (no hash)

I fixed the tag v2.9.0 to point to the commit where I built it.
* feat(css): accent color from purple to blue

Accent color in core-styles 0.13 (thus core-cms 3.10) was indeed purple.

But that was a bug, and Design refuses it be deployed to more sites.

* docs(css): note accent color change pr
- supports link plugins and image link attributes
- fixes link title (from image alt)
Base automatically changed from dev/tup-cms to main July 18, 2023 20:03
@wesleyboar wesleyboar mentioned this pull request Jul 18, 2023
@wesleyboar wesleyboar closed this Aug 11, 2023
@wesleyboar wesleyboar deleted the dev/tup-cms--django-v4 branch November 13, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant