Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tup-548 allow showing djangocms-icon label #696

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 22, 2023

Overview

Allow the "Label" field of an Icon plugin instance to be rendered as text on the page.

Background

The "Label" field was only used for Structure Mode, to label the Icon plugin instance.

The use case is a Link plugin that needs an Icon and Text inside, but the Text plugin (by default) wraps content in a <p> tag, so this will let us avoid that <p> tag by not using Text plugin—just show the Icon "LabeL" to get non-<p> text.

Related

Changes

  • added new template "show_label"

Testing

UI

wesleyboar and others added 2 commits August 22, 2023 09:57
The "Label" field was only used for Structure Mode.

If "Label" field value is content, an Icon inside Link can set text too.
@wesleyboar wesleyboar added paused Started but not actively in progress feature A new feature or replacement of present feature enhancement Improvements or additions to existing features and removed feature A new feature or replacement of present feature labels Aug 24, 2023
@wesleyboar wesleyboar added the priority ▼▼ Very low priority label Nov 13, 2023
@wesleyboar wesleyboar changed the title feat: tup-548 allow showign djangocms-icon label feat: tup-548 allow showing djangocms-icon label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features paused Started but not actively in progress priority ▼▼ Very low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant