Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: support template overwrite not inheritance #710

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

enhance: support template overwrite not inheritance #710

wants to merge 6 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 29, 2023 •
edited
Loading

Overview

Clean up templates in a way that supports https://github.com/TACC/Core-CMS-Custom and https://github.com/TACC/tup-ui overwrites of them.

Related

Testing & UI

  1. Deploy all sites that {% block assets_… %}.
  2. Verify relevant UI (from custom assets is unchanged) i.e. matches prod.

See:

Changes

  • moved favicon render from assets_custom to assets_core
  • added example in assets_custom of how to customize fonts
  • removed now-unnecessary comments from many templates
  • moved page_title to base (so no need to mass duplicate)

@wesleyboar wesleyboar changed the title enhance: clean up templates enhance: clean up templates to support overwrite not inheritance Aug 29, 2023
@wesleyboar wesleyboar changed the title enhance: clean up templates to support overwrite not inheritance enhance: support template overwrite not inheritance Aug 29, 2023
wesleyboar added a commit to TACC/Core-CMS-Resources that referenced this pull request Aug 29, 2023
@wesleyboar
chore: move page_attribute "page_title" to base
e6f4cd9 
Requires: TACC/Core-CMS#710
@wesleyboar wesleyboar mentioned this pull request Aug 29, 2023
Draft
@wesleyboar wesleyboar added the enhancement Improvements or additions to existing features label Aug 29, 2023
@wesleyboar
chore: move page_attribute "page_title" to base
9e892c6 
There is no reason to do this on every template.

I had continued doing it, because I feared breaking things.

I know enough about the templates now to know repition was unnecessary.
@wesleyboar
chore: move favicon markup to core assets
4086324 
In assets_custom, it was copied by CMS in Core-CMS-Custom and tup-ui.

Stop copying. No one ever changes it. Settings do that. Let Core lead.
@wesleyboar wesleyboar mentioned this pull request Aug 29, 2023
Draft
This was referenced Nov 13, 2023
Closed
Closed
@wesleyboar wesleyboar added the paused Started but not actively in progress label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements or additions to existing features paused Started but not actively in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar