Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-97 add content around news list #850

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 16, 2024

Overview

Add content around article list on News page.

Related

Changes

Depends on commit.

Testing

  1. Have a CMS with News app installed and working.
  2. Open http://localhost:8000/.
  3. View page Structure.
  4. Verify nothing is changed.
  5. Open http://localhost:8000/news/.
  6. View page Structure.
  7. Verify "Content" placeholder is available.
  8. Add "Text" plugin, with some text, to "Content".
  9. Verify your text is visible on the page.
  10. Verify article list and title is still visible on the page.
  11. 🆕 Visit an article page.
  12. 🆕 ❌ Verify your text is not visible on the page.

UI

Solution C

C.3. Add "Content" to News (fa9b84d)

Caution

  • Same content appears on News List and News Article pages.
  • Admin requires Dev to move content (via template or CSS).
Home News
C3 Add Content to News - Home (No Change) C3 Add Content to News - News (New Placeholder)

C.2. Add 4 New Placeholders to All Pages (similar to 8187a20)

Caution

  • Placeholder available on all pages.
  • Same content appears on News List and News Article pages.
  • Admin requires dev to move content (via template or CSS).
Home News
C2 Positional Placeholders - Home C2 Positional Placeholders - news

C.1. Add 1 Placeholder to All Pages (similar to 8187a20)

Caution

  • Placeholder available on all pages.
  • Same content appears on News List and News Article pages.
  • Admin requires dev to move content (via template or CSS).
Home News
C1 An Extra Placholder - Home C1 An Extra Placholder - News

Solution B

Tip

Ideal solution.

Full layout control for editor, likely via plugin that borrows from Blog plugin. Not achieved. Daunting. Details (internal).

Solution A

Caution

  • No pagination.

Include News via Blog plugin. Cancelled. Would not have pagination, but pagination is required. Details (internal).

This reverts commit fa9b84d.

This is nice, but has unexpected side effect of adding 'Content' placeholder to News page.
Drawback: Not just for News page. Goal of CMD-97 is just News page.
@wesleyboar wesleyboar marked this pull request as draft July 16, 2024 21:42
@wesleyboar wesleyboar added paused Started but not actively in progress priority ▼ Low priority labels Jul 16, 2024
@wesleyboar wesleyboar changed the title feat: cmd-97 add content around news list feat: CMD-97 add content around news list Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused Started but not actively in progress priority ▼ Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant