Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WP-197 use @layer's / help migrate Frontera #856

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 25, 2024

Overview

Use @layer for Core-CMS stylesheets loaded when TACC_CORE_STYLES_VERSION=0.

Frontera migration — TACC/Core-CMS-Custom#293 — uses @layers, but then Frontera styles yield to Core-CMS styles.

They yield to Core-CMS because Core-CMS — with TACC_CORE_STYLES_VERSION=0 — has all its styles in an anonymous layer.

(CSS in an anonymous layer beats CSS in a named layer.)

Related

Changes

  1. refactored site assets to load in @layer's
  2. refactored blog assets to load in @layer
    (only to match TACC_CORE_STYLES_VERSION=2 CMS use of @layer's)

Testing / UI

Notes

PR Problems That Have Since Been Fixed
❌ Error cloning #css-booststrap node cuz it does not exist now.
Core-CMS 856 Error

Frontera migration —
TACC/Core-CMS-Custom#293
— uses @layers, but then Frontera styles yield to Core-CMS styles.

They yield to Core-CMS because Core-CMS —
with `TACC_CORE_STYLES_VERSION=0`
— has all its styles in an anonymous layer.

(CSS in an anonymous layer beats CSS in a named layer.)
@wesleyboar wesleyboar force-pushed the feat/WP-197-use-css-layers-to-help-migrate-frontera branch from 865cd70 to ebe86e4 Compare July 25, 2024 19:32
@wesleyboar wesleyboar changed the title feat: WP-197 use @layer's / help migrate Frontera feat: WP-197 use @layer's / help migrate Frontera ⚠️ Sep 20, 2024
@wesleyboar wesleyboar changed the title feat: WP-197 use @layer's / help migrate Frontera ⚠️ feat: WP-197 use @layer's / help migrate Frontera Sep 20, 2024
@wesleyboar wesleyboar marked this pull request as ready for review September 20, 2024 23:54
Recent CSS fix for header was only applied to v1-origin sites.

The fix should be applied to v4.18+ sites.
@wesleyboar wesleyboar merged commit 7843331 into main Oct 1, 2024
@wesleyboar wesleyboar deleted the feat/WP-197-use-css-layers-to-help-migrate-frontera branch October 1, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant