bug/FP-896: Fix add definition to list #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 63.06% 63.45% +0.38%
==========================================
Files 371 186 -185
Lines 11281 4520 -6761
Branches 1868 1140 -728
==========================================
- Hits 7114 2868 -4246
+ Misses 3864 1538 -2326
+ Partials 303 114 -189
Flags with carried forward coverage won't be shown. Click here to find out more. |
nathanfranklin
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
LGTM! Thanks for fixing.
Do we need a ticket for handling these unhandled exceptions in our reducers? I'll create that as we've seen this with different regressions. EDIT: @rstijerina added ticket https://jira.tacc.utexas.edu/browse/FP-900
I've also added a note to cover these reducers with unit tests during some planned refactor in https://jira.tacc.utexas.edu/browse/FP-872 but see you have already started that! 💯
jchuahtacc
approved these changes
Feb 5, 2021
|
Merging, pipelines were working before poetry broke itself |
wesleyboar
pushed a commit
that referenced
this pull request
Jan 7, 2022
* fix add definition to list * add system def list unit test Co-authored-by: Owais Jamil <47395902+owaisj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Fixes adding definitions to the
state.definitions.listvia theaddSystemDefinitionfunction indatafiles.reducers.js.Related Jira tickets:
Summary of Changes:
Testing Steps: