Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/wi 46 Add CSP http headers #829

Closed
wants to merge 3 commits into from
Closed

Conversation

chandra-tacc
Copy link
Collaborator

@chandra-tacc chandra-tacc commented Jul 14, 2023

Overview

To become fully secure site, adding detailed Content Security Policy is needed.
This uses django-csp to enable csp.

Related

Changes

This PR adds CSP headers for

  • font src
  • script src
  • style src
  • connect src
    Also, ensure the current script tags use nonce.
    The setup right now is in "report only" mode to allow for opt-in and fully functional app.

Testing

  1. Validated the site using UI and reducing console warnings.

UI

No UI change.

Notes:

At this point, due to possibly breaking the app due to CSP, this PR is in draft mode. Other mitigations are deployed via TACC/Camino#32

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #829 (00f369e) into main (97dc0b5) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   64.33%   64.28%   -0.06%     
==========================================
  Files         426      426              
  Lines       12537    12547      +10     
  Branches     2510     2510              
==========================================
  Hits         8066     8066              
- Misses       4255     4265      +10     
  Partials      216      216              
Flag Coverage Δ
javascript 68.70% <ø> (ø)
unittests 60.33% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/portal/settings/settings.py 0.00% <0.00%> (ø)
server/portal/settings/settings_default.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants