Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/WP-408: use archiveSystemId set in app definition as default #917

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

rstijerina
Copy link
Member

@rstijerina rstijerina commented Dec 7, 2023

Overview

Use archiveSystemId value set in app definition if provided.

Related

Testing

  1. Go to https://cep.test/workbench/applications/opensees-mp-ls6
  2. Confirm the "Archive System" field shows cloud.data, which is the archiveSystemId of this app, instead of frontera, which is the default system locally.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #917 (35193ba) into main (afed181) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   63.46%   63.47%           
=======================================
  Files         431      431           
  Lines       12419    12422    +3     
  Branches     2590     2593    +3     
=======================================
+ Hits         7882     7885    +3     
  Misses       4321     4321           
  Partials      216      216           
Flag Coverage Δ
javascript 69.73% <100.00%> (+0.01%) ⬆️
unittests 57.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt/src/components/Applications/AppForm/AppForm.jsx 84.08% <100.00%> (+0.19%) ⬆️
...plications/AppForm/fixtures/AppForm.app.fixture.js 100.00% <ø> (ø)

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I can confirm that with this fix, the archiveSystem is not frontera.
It uses cloud.data and the output files are in this storage host: cloud.data.tacc.utexas.edu
Screenshot 2023-12-07 at 5 53 45 PM

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chandra-tacc chandra-tacc merged commit c089760 into main Dec 11, 2023
6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-408--app-archive-default branch December 11, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants