Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: update node to LTS (20.x), GH actions, and resolve security alerts #940

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

rstijerina
Copy link
Member

@rstijerina rstijerina commented Mar 19, 2024

Overview

  • Update's node to LTS 20.x
  • Updates github actions to latest versions
  • Update cyrptography and pyOpenSSL to resolve security alerts

Testing

  1. make build
  2. make start
  3. Ensure server side runs smoothly
  4. Locally, use node 20.x to npm ci and npm run dev and ensure all functions normally

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.72%. Comparing base (8548fea) to head (53cacd0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   64.72%   64.72%           
=======================================
  Files         431      431           
  Lines       12457    12457           
  Branches     2604     2600    -4     
=======================================
  Hits         8063     8063           
  Misses       4165     4165           
  Partials      229      229           
Flag Coverage Δ
javascript 69.83% <ø> (ø)
unittests 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rstijerina rstijerina changed the title Quick: update node to LTS (20.x) Quick: update node to LTS (20.x), GH actions, and resolve security alerts Mar 19, 2024
Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested locally and portal works well. I have node 21+

Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested using node 20.11.1

@rstijerina rstijerina merged commit 5af7a65 into main Mar 20, 2024
6 checks passed
@rstijerina rstijerina deleted the quick/update-node-lts branch March 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants