Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stampede3 to allocation list and system monitor list #943

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

chandra-tacc
Copy link
Collaborator

Overview

Stampede3 is part of TACC-ACI allocation and is usable for testing.

Related

Changes

  • tas_to_tacc_resources.json is matched against available allocations in tas. Need to keep this json updated.
  • system monitor list adjustment

Testing

  1. Allocation shows Stampede3
    Screenshot 2024-04-04 at 3 08 35 PM

  2. System Monitor: TAS is still not updated for Stampede3, so that shows as maintenance. https://tap.tacc.utexas.edu/status does not show stampede3 yet.
    Screenshot 2024-04-04 at 3 11 35 PM

UI

Notes

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.77%. Comparing base (487b952) to head (3cfbda2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         434      434           
  Lines       12474    12474           
  Branches     2600     2570   -30     
=======================================
  Hits         8080     8080           
  Misses       4165     4165           
  Partials      229      229           
Flag Coverage Δ
javascript 69.83% <ø> (ø)
unittests 59.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/portal/settings/settings.py 0.00% <ø> (ø)
server/portal/settings/settings_default.py 0.00% <0.00%> (ø)

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the current way Core is handling systems in tas_to_tacc_resources.json. Maybe I could look into TUP to see how projects pull in allocations and their corresponding systems without having to update a list later down the line. A similar solution could work for the system monitor table as well. We could implement that solution here but that is out of scope for this PR and not needed for this change.

@chandra-tacc
Copy link
Collaborator Author

LGTM with the current way Core is handling systems in tas_to_tacc_resources.json. Maybe I could look into TUP to see how projects pull in allocations and their corresponding systems without having to update a list later down the line. A similar solution could work for the system monitor table as well. We could implement that solution here but that is out of scope for this PR and not needed for this change.

Thanks @sophia-massie for that insight on TUP. This definitely could use some improvement. I added this task WP-544 to myself, to also look into this.

@chandra-tacc chandra-tacc merged commit aa40f49 into main Apr 4, 2024
5 of 6 checks passed
@chandra-tacc chandra-tacc deleted the quick/allocation-stampede3 branch April 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants