-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP-371: Use set-facl job for workspace ACLs #967
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 65.26% 65.29% +0.02%
==========================================
Files 438 438
Lines 12688 12703 +15
Branches 2669 2638 -31
==========================================
+ Hits 8281 8294 +13
- Misses 4171 4173 +2
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -194,6 +194,7 @@ | |||
_PORTAL_PROJECTS_ROOT_HOST = 'cloud.data.tacc.utexas.edu' | |||
_PORTAL_PROJECTS_SYSTEM_PORT = "22" | |||
_PORTAL_PROJECTS_PEMS_APP_ID = "" # Defunct in v3 | |||
_PORTAL_PROJECTS_USE_SET_FACL_JOB = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enable this by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll make sure to create credentials for cloud.data (wma_prtl) on all tenants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works locally
Overview
Uses setfacl job (see PR) to set ACLs on project folder during add/remove/role change operations
Related
WP-371
SetFacl app PR: TACC/WMA-Tapis-Templates#55
Changes
Differences from DesignSafe
Passing role to the setfacl app. Based on the role, the permission bits are adjusted.
Testing
For quicker testing, the feature is deployed to https://dev.cep.tacc.utexas.edu/
Verification
Add:
core portal logs
tapis job output
Update role
core portal logs
tapis job output
Remove
core portal logs
tapis job output
UI
Notes