Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): align + blockquote width mgmt. #115

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 22, 2023

Overview / Changes

  • Add .align component and pattern.
  • Fix <blockquote> width constraints.

Related

Testing

Review http://localhost:3000/components/detail/align.

UI

demo wide narrow
demo wide narrow

Notes

This components came from Core-CMS, but is useful enough for:

  • TACC-Docs
  • News Articles (which will appear outside CMS, in TUP for user News)

Known Issues

  1. A figure.s-blockquote seems unable to be automatically-centered with automatic width.

This components came from Core-CMS, but is useful enough for:
- TACC-Docs
- News Articles (which will appear outside CMS, in TUP for user News)

The max-width for blockquotes should only be applied when the blockquote is aligned left or right (which I was testing at the saem time as #114).
@wesleyboar wesleyboar merged commit b622693 into main Jan 22, 2023
@wesleyboar wesleyboar deleted the task/align-component-from-core-cms-from-djangocms-picture branch January 22, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant