Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elements): fake table using paragraphs #126

Merged
merged 6 commits into from
Feb 14, 2023
Merged

feat(elements): fake table using paragraphs #126

merged 6 commits into from
Feb 14, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 14, 2023 •
edited
Loading

Overview

Allow a single-column table to built from paragraphs.

Related

None.

Changes

  • feat(css): .pargagraph-table
  • feat(demo): table--fake

Testing

  1. Open http://localhost:3000/components/detail/table--fake.
  2. Verify paragraph-based table matches real table with no thead.*
  3. Open http://localhost:3000/components/detail/s-paragraph-table.
  4. Verify table matches the one from step 1.

* Ignore the right border on the real table. That is a bug with real single-column tables.

UI

trumps elements
trumps elements

@wesleyboar wesleyboar marked this pull request as draft February 14, 2023 19:50
@wesleyboar wesleyboar marked this pull request as ready for review February 14, 2023 20:31
@wesleyboar wesleyboar merged commit 1b9010e into main Feb 14, 2023
@wesleyboar wesleyboar deleted the task/fake-tables-using-paragraphs branch February 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar