Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demo): add buttons to link demos #136

Merged
merged 4 commits into from
Mar 3, 2023
Merged

feat(demo): add buttons to link demos #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8e178a
feat(demo): add buttons to link demos
wesleyboar Mar 3, 2023
032c418
fix(demo): links, regular & irregular, consistency
wesleyboar Mar 3, 2023
9a78410
chore(demo): links, simpler markup
wesleyboar Mar 3, 2023
9674864
chore(components): del. future code that snuck in
wesleyboar Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/_imports/_partials/text-and-button-as-link.hbs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions src/lib/_imports/_partials/text-and-button.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>{{#if label}}<strong>{{{ label }}}:</strong> {{/if}}Pack my red box with five dozen quality jugs. A quick brown fox jumps over the <button{{#if class}} class="{{class}}"{{/if}}>lazy dog</button>. A waxy gent chuckled over my fab jazzy quips.</p>
2 changes: 1 addition & 1 deletion src/lib/_imports/_partials/text-and-link-no-href.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<p>Pack my red box with five dozen quality jugs. A quick brown fox jumps over the <a>lazy dog</a> (with no <code>href</code> attribute). A waxy gent chuckled over my fab jazzy quips.</p>
<p>{{#if label}}<strong>{{{ label }}}:</strong> {{/if}}Pack my red box with five dozen quality jugs. A quick brown fox jumps over the <a>lazy dog</a> (with no <code>href</code> attribute). A waxy gent chuckled over my fab jazzy quips.</p>
2 changes: 1 addition & 1 deletion src/lib/_imports/_partials/text-and-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<p>Pack my red box with five dozen quality jugs. A quick brown fox jumps over the <a href="#">lazy dog</a>. A waxy gent chuckled over my fab jazzy quips.</p>
<p>{{#if label}}<strong>{{{ label }}}:</strong> {{/if}}Pack my red box with five dozen quality jugs. A quick brown fox jumps over the <a href="#">lazy dog</a>. A waxy gent chuckled over my fab jazzy quips.</p>
18 changes: 10 additions & 8 deletions src/lib/_imports/elements/links/links.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
<dl class="demo-narrow-paragraphs">
<dt>Standard</dt>
<dd>
{{> @text-and-link }}
</dd>
<dd>
{{> @text-and-link-no-href }}
{{> @text-and-link label="Normal" }}

{{> @text-and-link-no-href label="No <code>href</code>" }}

{{> @text-and-button label="Button" class="c-button c-button--as-link" }}
</dd>
<dt>Irregular</dt>
<dd class="s-irregular-links">
{{> @text-and-link }}
</dd>
<dd>
{{> @text-and-link-no-href }}
{{> @text-and-link label="Normal" }}

{{> @text-and-link-no-href label="No <code>href</code>" }}

{{> @text-and-button label="Button as Link" class="c-button c-button--as-link" }}
</dd>
</dl>
16 changes: 4 additions & 12 deletions src/lib/_imports/trumps/s-irregular-links/s-irregular-links.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
<dl class="demo-narrow-paragraphs s-irregular-links">
<dt>Links</dt>
<dt>Normal</dt>
<dd>
{{> @text-and-link }}
</dd>
<dt>No <code>href</code></dt>
<dd>
{{> @text-and-link-no-href }}
</dd>
<dt>Button as Link</dt>
<dd>
{{> @text-and-button-as-link }}
</dd>
<dt>Buttons as Links</dt>
<dd>
{{> @text-and-link }}
</dd>
<dd>
{{> @text-and-link-no-href }}
</dd>
<dd>
{{> @text-and-button-as-link }}
{{> @text-and-button class="c-button c-button--as-link" }}
</dd>
</dl>